perf(browserless): clear per-request cleanup timers#662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk: change is limited to per-request timeout cleanup in
withPage, with added test coverage; main risk is altering timing behavior of forced page closure under long-running requests.Overview
Prevents lingering per-request cleanup timers in
withPageby keeping a handle to thesetTimeoutthat force-closes the page, safelyunref-ing it when available, and alwaysclearTimeout-ing it in afinallyblock after success/error.Adds a regression test that verifies these
closePagecleanup timers are cleared after a successfulwithPagerun by instrumentingsetTimeout/clearTimeoutand asserting all created timers are cleared.Written by Cursor Bugbot for commit e15a996. This will update automatically on new commits. Configure here.