Skip to content

perf(browserless): clear per-request cleanup timers#662

Merged
Kikobeats merged 1 commit intomasterfrom
codex/fix-withpage-clear-timeout
Feb 26, 2026
Merged

perf(browserless): clear per-request cleanup timers#662
Kikobeats merged 1 commit intomasterfrom
codex/fix-withpage-clear-timeout

Conversation

@Kikobeats
Copy link
Member

@Kikobeats Kikobeats commented Feb 26, 2026

Note

Low Risk
Low risk: change is limited to per-request timeout cleanup in withPage, with added test coverage; main risk is altering timing behavior of forced page closure under long-running requests.

Overview
Prevents lingering per-request cleanup timers in withPage by keeping a handle to the setTimeout that force-closes the page, safely unref-ing it when available, and always clearTimeout-ing it in a finally block after success/error.

Adds a regression test that verifies these closePage cleanup timers are cleared after a successful withPage run by instrumenting setTimeout/clearTimeout and asserting all created timers are cleared.

Written by Cursor Bugbot for commit e15a996. This will update automatically on new commits. Configure here.

@Kikobeats Kikobeats merged commit 21b7366 into master Feb 26, 2026
18 of 20 checks passed
@Kikobeats Kikobeats deleted the codex/fix-withpage-clear-timeout branch February 26, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant