fix(screencast): guard frame callback and cleanup listeners#661
Closed
fix(screencast): guard frame callback and cleanup listeners#661
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| if (typeof cdp.off === 'function') { | ||
| cdp.off('Page.screencastFrame', onScreencastFrame) | ||
| } else if (typeof cdp.removeListener === 'function') { | ||
| cdp.removeListener('Page.screencastFrame', onScreencastFrame) |
There was a problem hiding this comment.
Screencast cannot restart after first stop
Medium Severity
stop() now permanently removes the Page.screencastFrame listener and flips isStopped, but start() never reattaches that listener or resets state. Reusing the same instance after one stop causes frames to stop being processed and acknowledged, and later stop() calls become no-ops for subsequent recording sessions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk: small, localized lifecycle fixes to event handling with added unit coverage; main risk is behavior change around when frames are delivered/ignored and how stop is handled across CDP implementations.
Overview
Hardens the screencast frame handler by guarding
onFrameso earlyPage.screencastFrameevents don’t throw, while still acking frames.Makes
stop()idempotent and removes thePage.screencastFramelistener on stop (supporting bothcdp.offandremoveListener) to prevent leaks/double-processing, and adds AVA unit tests covering both behaviors.Written by Cursor Bugbot for commit 74ecf1d. This will update automatically on new commits. Configure here.