Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hub footer cleanup (Twitter = X and remove Zulip) #129

Closed
wants to merge 5 commits into from

Conversation

Nachiket-Roy
Copy link
Contributor

Replaced Twitter with X and removed Zulip.
fixes #128

Copy link

👋 @Nachiket-Roy

Welcome to the Microcks community! 💖

Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly.

Hope you have a great time there!

🌟 ~~~~~~~~~ 🌟

📢 If you like Microcks, please ⭐ star ⭐ our repo to support it!

🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact.

Copy link
Member

@yada yada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the change requested and thanks for this one.
Please sign your PR (see DCO check, mandatory) and I'll be happy to merge it.

@Nachiket-Roy
Copy link
Contributor Author

requested changes have been made and PR has been signed

@yada
Copy link
Member

yada commented Mar 26, 2025

Thanks for the changes, good for me.
But please fix the DCO check (click on it for how to): this is mandatory for CNCF contributions.

Nachiket-Roy and others added 5 commits March 26, 2025 21:36
Signed-off-by: Nachiket <[email protected]>
)

* docs: Fix 404 link in create-api-mocks documentation (#125)

Signed-off-by: rissh <[email protected]>

* docs: Fix 404 link in create-api-mocks documentation (Multi-artifacts support) (#126)

Signed-off-by: rissh <[email protected]>

---------

Signed-off-by: rissh <[email protected]>
Co-authored-by: rissh <[email protected]>
Signed-off-by: Nachiket <[email protected]>
Copy link
Member

@yada yada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, we only expect file change in frontend/src/app/components/footer-bar/footer-bar.component.html

Please remove the other commits, as they have already been merged in a different PR. I assume you've not performed a pull in the meantime.

@rissh
Copy link
Contributor

rissh commented Mar 27, 2025

Yeah, looks like he kinda messed up here. As @yada said, he ended up adding some of my commits too. 😅

@Nachiket-Roy Nachiket-Roy closed this by deleting the head repository Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hub footer cleanup (Twitter = X and remove Zulip)
3 participants