-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hub footer cleanup (Twitter = X and remove Zulip) #129
Conversation
Welcome to the Microcks community! 💖 Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly. Hope you have a great time there! 🌟 ~~~~~~~~~ 🌟 📢 If you like Microcks, please ⭐ star ⭐ our repo to support it! 🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the change requested and thanks for this one.
Please sign your PR (see DCO check, mandatory) and I'll be happy to merge it.
requested changes have been made and PR has been signed |
Thanks for the changes, good for me. |
Signed-off-by: Nachiket <[email protected]>
Signed-off-by: Nachiket <[email protected]>
Signed-off-by: Nachiket <[email protected]>
Signed-off-by: rissh <[email protected]> Co-authored-by: rissh <[email protected]> Signed-off-by: Nachiket <[email protected]>
) * docs: Fix 404 link in create-api-mocks documentation (#125) Signed-off-by: rissh <[email protected]> * docs: Fix 404 link in create-api-mocks documentation (Multi-artifacts support) (#126) Signed-off-by: rissh <[email protected]> --------- Signed-off-by: rissh <[email protected]> Co-authored-by: rissh <[email protected]> Signed-off-by: Nachiket <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, we only expect file change in frontend/src/app/components/footer-bar/footer-bar.component.html
Please remove the other commits, as they have already been merged in a different PR. I assume you've not performed a pull in the meantime.
Yeah, looks like he kinda messed up here. As @yada said, he ended up adding some of my commits too. 😅 |
Replaced Twitter with X and removed Zulip.
fixes #128