Removed date filter from failed_list.html.twig #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise you get this error:
An exception has been thrown during the rendering of a template ("DateTime::__construct(): Failed to parse time string (di mrt 26 12:46:53 UTC 2013) at position 0 (d): The timezone could not be found in the database") in BCCResqueBundle:Default:failed_list.html.twig at line 21.
|
Grrr. Works OK with 'en' as a locale. Might it be worth submitting a PR to php-resque to use ISO 8601 for failed_at? Meanwhile, I will merge and tag. |
tonypiper
added a commit
that referenced
this pull request
Mar 27, 2013
Removed date filter from failed_list.html.twig
|
tagged v1.1.6 |
|
There is already a PR for this: chrisboulton/php-resque#95 |
|
Great. Hope it gets merged soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise you get this error:
An exception has been thrown during the rendering of a template ("DateTime::__construct(): Failed to parse time string (di mrt 26 12:46:53 UTC 2013) at position 0 (d): The timezone could not be found in the database") in BCCResqueBundle:Default:failed_list.html.twig at line 21.
This is because PHP-Resque uses a localized timestamp: