Let's improve everything: less spaghetti code, scan algorithm and CI improvement, lighter binary

.github/.yamllint.yml

@@ -0,0 +1,2 @@
+rules:
+  line-length: disable

.github/workflows/ci.yml

@@ -0,0 +1,161 @@
+name: CI
+
+on: [push, pull_request]
+
+jobs:
+  setup:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Cancel previous
+        uses: styfle/cancel-workflow-action@0.8.0
+        with:
+          access_token: ${{ github.token }}
+
+  unit-tests:
+    strategy:
+      matrix:
+        go-version: [1.x, 1.16.x]
+        platform: [ubuntu-latest, macos-latest, windows-latest]
+        include:
+          - go-version: 1.x
+            platform: ubuntu-latest
+            update-coverage: true
+    runs-on: ${{ matrix.platform }}
+    needs: [setup]
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+
+      - name: Setup Go
+        uses: actions/setup-go@v2
+        with:
+          go-version: ${{ matrix.go-version }}
+
+      - name: Cache go modules
+        uses: actions/cache@v2
+        with:
+          path: ~/go/pkg/mod
+          key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
+          restore-keys: ${{ runner.os }}-go-
+
+      - name: Run go fmt
+        if: runner.os != 'Windows'
+        run: diff -u <(echo -n) <(gofmt -d -s .)
+
+      - name: Ensure go generate produces a zero diff
+        shell: bash
+        run: go generate -x ./... && git diff --exit-code; code=$?; git checkout -- .; (exit $code)
+
+      - name: Run go vet
+        run: go vet ./...
+
+      - name: Run go test
+        run: go test -v -race -coverprofile coverage.txt ./...
+
+      - name: Upload coverage to Codecov
+        if: ${{ matrix.update-coverage }}
+        uses: codecov/codecov-action@v1
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+
+  chopchop-endpoint:
+    runs-on: ubuntu-latest
+    needs: [setup]
+    steps:
+     - uses: actions/checkout@v1
+     - run: |
+        cat chopchop.yml | grep "uri:" | sort | uniq -c | sort -n
+        test=`cat chopchop.yml | grep "endpoint:" | sort | uniq -c | grep -v 1 | wc -l`
+        if [ $test != 0 ]; then echo "There shouldn't be multiple (and identical) 'endpoint'. It should be refactored. "; exit 1; fi
+
+  go-lint:
+    runs-on: ubuntu-latest
+    needs: [setup]
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-go@v2
+        with:
+          go-version: 1.16.x
+
+      - name: go-lint
+        run: |
+          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.39.0
+          golangci-lint run
+
+  yaml-lint:
+    runs-on: ubuntu-latest
+    needs: [setup]
+    steps:
+      - uses: actions/checkout@v2
+      - name: yaml-lint
+        uses: ibiqlik/action-yamllint@v3
+        with:
+          file_or_dir: chopchop.yml
+          config_file: .github/.yamllint.yml
+
+  functional-tests:
+    runs-on: ubuntu-latest
+    needs: [unit-tests, chopchop-endpoint, go-lint, yaml-lint]
+    steps:
+    - uses: actions/checkout@v2
+    - uses: actions/setup-go@v2
+      with:
+        go-version: 1.16.x
+
+    - name: Install RobotFramework
+      run: pip install robotframework
+
+    - name: Run RobotFramework tests
+      run: |
+        cd robot
+        ./run.sh
+
+    - name: Upload Robot outputs
+      uses: actions/upload-artifact@v2
+      with:
+        name: robot-output
+        path: robot/out/*
+
+  build-and-publish:
+    runs-on: ubuntu-latest
+    needs: [functional-tests]
+    if: ${{ github.event_name == 'push' }}
+    steps:
+    - name: Install Go
+      uses: actions/setup-go@v2
+      with:
+        go-version: 1.16.x
+
+    - name: Checkout code
+      uses: actions/checkout@v2
+
+    - name: Cache go modules
+      uses: actions/cache@v2
+      with:
+        path: ~/go/pkg/mod
+        key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
+        restore-keys: ${{ runner.os }}-go-
+
+    - name: Install gox
+      run: go get github.com/mitchellh/gox
+
+    - name: Build using gox
+      run: |
+        cd cmd
+        gox -ldflags "-X main.Version=$BUILD_VERSION -X main.BuildDate=$BUILD_DATE" \
+          -output "../artifacts/ChopChop_{{.OS}}_{{.Arch}}" \
+          -osarch="!darwin/386"
+
+    - name: Upload ChopChop builds
+      uses: actions/upload-artifact@v2
+      with:
+        name: chopchop-artifacts
+        path: artifacts/*
+
+    - name: Release
+      uses: fnkr/github-action-ghr@v1
+      if: startsWith(github.ref, 'refs/tags/')
+      env:
+        GHR_COMPRESS: gz
+        GHR_PATH: artifacts/
+        GITHUB_TOKEN: ${{ secrets.DEPLOY_TOKEN }}

.github/workflows/docker-publish.yml

@@ -10,53 +10,23 @@ on:
     tags:
       - v*
 
-  # Run tests for any PRs.
-  pull_request:
-
 env:
   IMAGE_NAME: gochopchop
 
 jobs:
-  # Run tests.
-  # See also https://docs.docker.com/docker-hub/builds/automated-testing/
-  test:
-    runs-on: ubuntu-latest
-
-    steps:
-      - uses: actions/checkout@v2
-
-      - name: Run tests
-        run: |
-          if [ -f docker-compose.test.yml ]; then
-            docker-compose --file docker-compose.test.yml build
-            docker-compose --file docker-compose.test.yml run sut
-          else
-            docker build . --file Dockerfile
-          fi
-
   # Push image to GitHub Packages.
   # See also https://docs.docker.com/docker-hub/builds/
   push:
-    # Ensure test job passes before pushing image.
-    needs: test
-
     runs-on: ubuntu-latest
-    if: github.event_name == 'push'
-
     steps:
-      - name: Install Go
-        uses: actions/setup-go@v2
-        with:
-          go-version: 1.14.x
+      - name: Log into GitHub Container Registry
+      # The CR_PAT secret is a PAT with `read:packages` and `write:packages` scopes
+        run: echo "${{ secrets.CR_PAT }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin
+
       - uses: actions/checkout@v2
-      - name: Unit Tests
-        run: go test ./...
-      - name: Build image
-        run: docker build . --file Dockerfile --tag $IMAGE_NAME
 
-      - name: Log into GitHub Container Registry
-      # TODO: Create a PAT with `read:packages` and `write:packages` scopes and save it as an Actions secret `CR_PAT`
-        run: echo "${{ secrets.CR_PAT }}" | docker login https://ghcr.io -u ${{ github.actor }} --password-stdin
+      - name: Build image
+        run: docker build -t $IMAGE_NAME .
 
       - name: Push image to GitHub Container Registry
         run: |