Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump embedded HAL dependencies and update async API #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

robamu
Copy link
Contributor

@robamu robamu commented Oct 17, 2024

I tested both the blocking API and the updated asynchronous non-blocking API on a Raspberry Pi Pico.

One small thing where I wasn't sure what the best solution is:

dht11::asynch::read vs. dht11::read_async and the same for dht22 of course.

@michaelbeaumont
Copy link
Owner

One small thing where I wasn't sure what the best solution is:

Maybe there's some precedent here on maintaining async and non-async interfaces?

@robamu
Copy link
Contributor Author

robamu commented Oct 22, 2024

They are separated already, it's just a style question I guess. I would actually prefer the dht11::read and dht11::read_async version at this point. Or do you mean something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants