Skip to content

Refactor to support case when on first page and only one total pages #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions lib/scrivener/html/seo.ex
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,21 @@ defmodule Scrivener.HTML.SEO do
iex> Phoenix.HTML.safe_to_string(Scrivener.HTML.SEO.header_links(%Scrivener.Page{total_pages: 10, page_number: 3}))
"<link href=\"?page=2\" rel=\"prev\"></link>\n<link href=\"?page=4\" rel=\"next\"></link>"
"""
def header_links(conn, %Page{page_number: 1} = paginator, args, opts) do
next_header_link(conn, paginator, args, opts)
end

def header_links(conn, %Page{total_pages: page, page_number: page} = paginator, args, opts) do
prev_header_link(conn, paginator, args, opts)
end

def header_links(conn, paginator, args, opts) do
{:safe, prev} = prev_header_link(conn, paginator, args, opts)
{:safe, next} = next_header_link(conn, paginator, args, opts)
{:safe, [prev, "\n", next]}
def header_links(
conn,
%Page{total_pages: total_pages, page_number: page_number} = paginator,
args,
opts
) do
prev = if page_number > 1, do: prev_header_link(conn, paginator, args, opts)
next = if total_pages > page_number, do: next_header_link(conn, paginator, args, opts)

if prev && next do
[{:safe, prev}, {:safe, next}] = [prev, next]
{:safe, [prev, "\n", next]}
else
prev || next
end
end

def header_links(%Scrivener.Page{} = paginator), do: header_links(nil, paginator, [], [])
Expand Down
6 changes: 5 additions & 1 deletion test/scrivener/html/seo_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,11 @@ defmodule Scrivener.HTML.SEOTest do
end

describe "#header_links" do
test "on the first page" do
test "on the first page with only one total pages" do
refute header_links(%Page{total_pages: 1, page_number: 1})
end

test "on the first page with more than one total pages" do
assert header_links(%Page{total_pages: 10, page_number: 1}) ==
{:safe,
[
Expand Down