Skip to content

Update README.md #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update README.md #24

wants to merge 3 commits into from

Conversation

@grasmash
Copy link

@grasmash grasmash commented Nov 14, 2023

No description provided.

mglaman
mglaman reviewed Nov 22, 2023
View reviewed changes
Copy link
Owner

@mglaman mglaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This content feels more like a blog post than documentation.

Also, the "Before" and "After" duplicate the "Try it" section and what it accomplishes. It feels like it should go after that and "Try it" can be renamed to "Usage"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mglaman mglaman mglaman left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@grasmash @mglaman