clean up unused assigned vars and add test

gerrydb_meta/crud/column.py

@@ -169,7 +169,6 @@ def set_values(
         Raises:
             ColumnValueTypeError: If column types do not match expected types.
         """
-        table_name=models.ColumnValue.__table__.name
         val_column = COLUMN_TYPE_TO_VALUE_COLUMN[col.type]
         now = datetime.now(timezone.utc)
 

gerrydb_meta/models.py

@@ -19,7 +19,6 @@
 from sqlalchemy.dialects import postgresql
 from sqlalchemy.orm import DeclarativeBase, Mapped, mapped_column, relationship, Session
 from sqlalchemy.sql import func
-from sqlalchemy.types import CHAR
 
 from gerrydb_meta.enums import (
     ColumnKind,

gerrydb_meta/utils.py

@@ -3,5 +3,5 @@
 
 def create_column_value_partition_text(geo_id: int):
     table_name=models.ColumnValue.__table__.name
-    sql=f"CREATE TABLE IF NOT EXISTS {models.SCHEMA}_{table_name}_{geo_id} PARTITION OF {models.SCHEMA}.{table_name} FOR VALUES IN ({geo_id})"
+    sql=f"CREATE TABLE IF NOT EXISTS {models.SCHEMA}.{table_name}_{geo_id} PARTITION OF {models.SCHEMA}.{table_name} FOR VALUES IN ({geo_id})"
     return text(sql)

tests/test_utils.py

@@ -0,0 +1,9 @@
+from gerrydb_meta.utils import create_column_value_partition_text
+from sqlalchemy import text
+
+def test_create_column_value_partition_text():
+    geo_id=42
+    got=create_column_value_partition_text(geo_id=geo_id)
+    wanted=text("CREATE TABLE IF NOT EXISTS gerrydb.column_value_42 PARTITION OF gerrydb.column_value FOR VALUES IN (42)")
+    #different object instances, so compare string form
+    assert str(got)==str(wanted)