Draft
Conversation
InnovativeInventor
force-pushed
the
retworkx
branch
from
e9eddbe to
a3000e3
Compare
InnovativeInventor
force-pushed
the
retworkx
branch
from
a3000e3 to
c814dda
Compare
InnovativeInventor
force-pushed
the
retworkx
branch
4 times, most recently
from
03f11ae to
fb5a961
Compare
InnovativeInventor
force-pushed
the
retworkx
branch
2 times, most recently
from
11828f3 to
5944f38
Compare
InnovativeInventor
force-pushed
the
retworkx
branch
from
59d6b3f to
8c34a91
Compare
Member
Author
|
The speedup should be > 16x now, for some computers at least. |
InnovativeInventor
force-pushed
the
retworkx
branch
from
e41f7f5 to
96cadd8
Compare
|
|
||
| def recom( | ||
| partition, pop_col, pop_target, epsilon, node_repeats=1, method=bipartition_tree | ||
| partition, pop_col, pop_target, epsilon, node_repeats=1, method=bipartition_tree_retworkx |
Member
Author
There was a problem hiding this comment.
Reminder to self: the method param gets ignored rn -- this should be fixed/changed.
InnovativeInventor
force-pushed
the
retworkx
branch
from
5b41e84 to
03725bb
Compare
This reverts commit 9e5f50b.
pjrule
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR (based off
perf-tuningthat rewrites the balance edge picking algorithm in Rust usingretworkx, yielding a ~16x speedup in chain run times).PA chain run times (congressional) are now at 50 it/s on my computer with commit e9eddbe (as opposed to ~3 it/s). This also leaves a few more low-hanging fruit optimizations on the table which could yield more speedups in the future.
Some of the new
retworkxcode has been upstreamed, other bits are in the process of being upstreamed. This PR works with myfeat-balanced-cut-edgesbranch here: https://github.com/InnovativeInventor/retworkx/tree/feat-balanced-cut-edges.