Skip to content

Commit

Permalink
code cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
mevljas committed Jan 19, 2025
1 parent 2ef339c commit 576ecc9
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 7 deletions.
15 changes: 15 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,21 @@ cd 'C:\Program Files\Google\Chrome\Application'
- Add database path to the **.env** file.
- Add discord channel ids and nepremicnine.net search url pairs to the **config.txt** file.

## Development

### Analyze the code

```bash
poetry run pylint $(git ls-files '*.py')
```

### Format the code

```bash
poetry run black .
```


## Run the bot

```bash
Expand Down
4 changes: 1 addition & 3 deletions services/discord_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,7 @@ async def my_background_task(self):
)

# Run the spider.
channel_listings = await run_spider(
database_manager=database_manager
)
channel_listings = await run_spider(database_manager=database_manager)

for channel_id, listings in channel_listings.items():
logging.debug("Sending listings to channel %s.", channel_id)
Expand Down
4 changes: 2 additions & 2 deletions services/extract_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ async def parse_page(
:return: dict[str, tuple[str, str | None, str, float, float, int, str | None, str | None]], bool
"""

logger.debug("Parsing page %s.",browser_page.url)
logger.debug("Parsing page %s.", browser_page.url)

# Reject cookies.
await browser_page.get_by_role("button", name="Zavrni").click()
Expand All @@ -41,7 +41,7 @@ async def parse_page(
await browser_page.locator("xpath=//*[@id='pagination']/ul/li[4]/a").count() > 0
)

logger.info("Parsing page %s finished.",browser_page.url)
logger.info("Parsing page %s finished.", browser_page.url)

return extracted_data, more_pages

Expand Down
7 changes: 5 additions & 2 deletions spider/spider.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ async def run_spider(database_manager: DatabaseManager):

# create a new page inside context.
browser_page = await browser.new_page(
user_agent="Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.110 Safari/537.36") # pylint: disable=line-too-long
user_agent="Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.110 Safari/537.36"
) # pylint: disable=line-too-long

# Prevent loading some resources for better performance.
# await browser_page.route("**/*", block_aggressively)
Expand All @@ -60,7 +61,9 @@ async def run_spider(database_manager: DatabaseManager):
await browser_page.goto(f"{page_url}{index}/")

try:
results_tmp, more_pages = await parse_page(browser_page=browser_page)
results_tmp, more_pages = await parse_page(
browser_page=browser_page
)
results.update(results_tmp)
except Exception as e: # pylint: disable=broad-except
logger.error("Error parsing page: %s", e)
Expand Down

0 comments on commit 576ecc9

Please sign in to comment.