-
Notifications
You must be signed in to change notification settings - Fork 4
Improve metapath exceptions for v3.0.0 #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Improve metapath exceptions for v3.0.0 #405
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
e1a9fb6
to
e573ff0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found one typo in a file name and an otherwise confusing doc string but all straightforward and solid. I am happy to approve this one now. It's up to you if you need me review again if you want to fix the file name but it's very minor.
.../src/main/java/gov/nist/secauto/metaschema/core/metapath/function/library/ArraySubarray.java
Show resolved
Hide resolved
...rc/main/java/gov/nist/secauto/metaschema/core/metapath/impl/ErroniousMetapathExpression.java
Outdated
Show resolved
Hide resolved
…s for array handling.
…ere root paths were not raising the correct MPDY0050 error when a node was used in the context that did not have a document node ancestor.
…o branches: StaticMetapathError and DynamicMetapathError. StaticMetapathErrors should be limited to compilation, while DynamicMetapathErrors should be limited to execution.
…ed a RuntimeMetapathError exception class that all runtime exceptions are now children of. Moved function-related exceptions to their own branch in the Metapath runtime error tree.
e573ff0
to
b237237
Compare
Committer Notes
Improve the overall Metapath exception hierarchy.
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
Changes to Core Features: