Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#102 update ruby-packer to 0.4.7 #103

Merged
merged 10 commits into from
Jun 25, 2021
Merged

#102 update ruby-packer to 0.4.7 #103

merged 10 commits into from
Jun 25, 2021

Conversation

CAMOBAP
Copy link
Contributor

@CAMOBAP CAMOBAP commented Jun 6, 2021

@CAMOBAP CAMOBAP self-assigned this Jun 6, 2021
@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented Jun 6, 2021

Looks like 0.4.7 use ruby-2.4.4, not ruby-2.5.1. @alexeymorozov could you please confirm?

@CAMOBAP CAMOBAP removed the request for review from Intelligent2013 June 6, 2021 06:17
@CAMOBAP CAMOBAP force-pushed the feature/ruby-packer-0.4.7 branch from 3e8f444 to 6f9ffb0 Compare June 6, 2021 10:12
@alemorozov
Copy link
Contributor

@CAMOBAP Yes, v0.4.7 uses Ruby 2.4.4. To use Ruby 2.5.1 please use v0.5.0, it was released today.

@CAMOBAP CAMOBAP force-pushed the feature/ruby-packer-0.4.7 branch from 6f9ffb0 to 254732c Compare June 6, 2021 17:44
@ronaldtse
Copy link
Contributor

@CAMOBAP some failures, I'm not sure if they are real:

  • NIST/BSI flavors failing due to missing sassc gem:
/__enclose_io_memfs__/local/vendor/bundle/ruby/2.5.0/gems/isodoc-1.6.3/lib/isodoc/css.rb:78:in `require': cannot load such file -- sassc (LoadError)
1007
	from /__enclose_io_memfs__/local/vendor/bundle/ruby/2.5.0/gems/isodoc-1.6.3/lib/isodoc/css.rb:78:in `convert_scss'
1008
	from /__enclose_io_memfs__/local/vendor/bundle/ruby/2.5.0/gems/isodoc-1.6.3/lib/isodoc/css.rb:100:in `generate_css'
1009
	from /__enclose_io_memfs__/local/vendor/bundle/ruby/2.5.0/gems/isodoc-1.6.3/lib/isodoc/css.rb:28:in `populate_css'
1010
	from /__enclose_io_memfs__/local/vendor/bundle/ruby/2.5.0/gems/isodoc-1.6.3/lib/isodoc/html_function/html.rb:10:in `block (2 levels) in convert1'
1011
  • Windows build failing

@ronaldtse
Copy link
Contributor

But the gems are not supposed to require sassc gem. Ping @opoudjis .

@opoudjis
Copy link

opoudjis commented Jun 7, 2021

Gems require sassc if you pull them from github, not if you run them from released version; is that what's going on here?

@ronaldtse
Copy link
Contributor

@opoudjis possibly, but the require is from isodoc:

isodoc-1.6.3/lib/isodoc/css.rb:78:in `require': cannot load such file -- sassc (LoadError)

@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented Jun 10, 2021

@ronaldtse @opoudjis as far as I understood, before publishing to rubygems.org we do scss -> css conversion somehow.

There is no relevant logic in Rakefiles, @opoudjis maybe you can confirm my assumption and explain how we can do this, so I will automate this

@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented Jun 10, 2021

Got all answers, thanks to @opoudjis

@CAMOBAP CAMOBAP force-pushed the feature/ruby-packer-0.4.7 branch from 254732c to 01e6be9 Compare June 10, 2021 13:40
@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented Jun 12, 2021

Both macOS and Linux are good

I still working on windows/OCRA related issues...

@CAMOBAP CAMOBAP force-pushed the feature/ruby-packer-0.4.7 branch from d7fe37a to 5d671a9 Compare June 12, 2021 15:12
@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented Jun 12, 2021

Current error

C:/Users/IEUser/AppData/Local/Temp/ocrD702.tmp/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require': 126: The specified module could not be found. - C:/Users/IEUser/AppData/Local/Temp/ocrD702.tmp/lib/ruby/2.7.0/x64-mingw32/openssl.so (LoadError)

Trounleshooting...

@CAMOBAP CAMOBAP force-pushed the feature/ruby-packer-0.4.7 branch 2 times, most recently from e073dff to d9885d0 Compare June 15, 2021 12:46
@CAMOBAP CAMOBAP force-pushed the feature/ruby-packer-0.4.7 branch from d9885d0 to 62431ad Compare June 15, 2021 13:06
@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented Jun 15, 2021

Next issue larsch/ocra#174

@ronaldtse
Copy link
Contributor

@CAMOBAP what has changed in Ocra that it no longer works?

@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented Jun 16, 2021

@ronaldtse no changes in ocra by itself, but we changed ruby version from 2. to 2.5

@ronaldtse
Copy link
Contributor

Got it, thanks @CAMOBAP !

@CAMOBAP CAMOBAP force-pushed the feature/ruby-packer-0.4.7 branch from 8717f05 to a7391f3 Compare June 25, 2021 10:37
@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented Jun 25, 2021

@ronaldtse finally the OCRA issue looks solved

But I have found out one serious problem metanorma will not work correctly if Gemfile is in current directory. This is why I added rm Gemfile as a workaround

We rarely faced with this issue before, but now it happens constantly because we use 'private' gem from github

My proposal to investigate this issue separately

@CAMOBAP CAMOBAP merged commit 11a1ca5 into master Jun 25, 2021
@CAMOBAP CAMOBAP deleted the feature/ruby-packer-0.4.7 branch June 25, 2021 15:02
@CAMOBAP CAMOBAP mentioned this pull request Jun 25, 2021
@ronaldtse
Copy link
Contributor

Makes sense. Thank you for tackling this issue @CAMOBAP !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants