Bump golang dependencies #504
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove pin versions Signed-off-by: karampok <[email protected]>
Signed-off-by: karampok <[email protected]>
karampok
force-pushed
the
bump-go-dep
branch
5 times, most recently
from
87c7cf5 to
b17e919
Compare
kind updated to have default version k8s 1.30 operator-sdk v1.38.0 moves to k8s 1.30 API's and Kubebuilder v4 Scaffolding, RBAC changed because the client-go bump start failing with error ``` pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:232: failed to list *v1.Deployment: deployments.apps is forbidd en: User "system:serviceaccount:metallb-system:manager-account" cannot list resource "deployments" in API group "apps" at the cluster scope ``` Signed-off-by: karampok <[email protected]>
|
@fedepaol after unpinning, there was a bit of mess (e.g. dep under require was updated x to y, but pined under replace in z, so when y never used, but when added manual the z the go mod start changing stuff ...). Anyway, I tried to clean the go.mod file, remove all the pins and tried to align everything around version1.30 and get a green ci. Pretty sure that you might find too many updates, not sure we can avoid it though. |
karampok
commented
Feb 7, 2025
|
|
||
| LeaderElection: *enableLeaderElection, | ||
| LeaderElectionID: "metallb.io.metallboperator", | ||
| // Namespace: envParams.Namespace, |
There was a problem hiding this comment.
This change is something what I need to double check ( in newer controller-runtime this field went away but did not see how was replaced)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a BUG FIX or a FEATURE ?:
What this PR does / why we need it:
Special notes for your reviewer:
Removed pin versions for kubernetes 1.27, not trivial because that was 2 years ago.
Update various parts to be aligned on k8s 1.30 (not pinned) like k8s.io/* to 1.30.z, k8s.io/client-go to 0.30.z, kind, operator-sdk, kustomize.
Release note: