refactor: Improve kind-cluster-with* scripts #395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace three scripts into one - Add kind cluster configurations in separate files - Enable registry by script parameter Fixes metallb#134 Signed-off-by: Vinu Kochukuttan <[email protected]>
fedepaol
reviewed
Nov 24, 2023
| esac | ||
| done | ||
|
|
||
| if [[ -z "${KIND_VERSION}" || -z "${CLUSTER_CONFIG}" ]]; then |
There was a problem hiding this comment.
I'd make the kind version optional and stick to some default
| set -o errexit | ||
|
|
||
| KIND_CLUSTER_NAME="${KIND_CLUSTER_NAME:-kind}" | ||
| KIND_VERSION="" |
There was a problem hiding this comment.
let's call this "KIND_NODE_VERSION" or "NODE_VERSION" or "KUBERNETES_VERSION" because this is not the version of kidn we are running
| @@ -52,7 +52,7 @@ jobs: | |||
|
|
|||
| - name: Create and set up K8s Kind Cluster | |||
| run: | | |||
| ./hack/kind-cluster-with-registry.sh | |||
| ./hack/kind-cluster.sh --kind-version v1.27.3 --cluster-config ./hack/kind-single-node-config.yaml --registry true | |||
There was a problem hiding this comment.
I'd add a flag single node / multinode rather than exposing which config to load from outside.
|
Also, the file must have the executable bit: /home/runner/work/_temp/57c09a5e-0aec-419c-bfd5-968945bef91b.sh: line 1: ./hack/kind-cluster.sh: Permission denied |
|
superseeded by #424 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134