🌱 Update MariaDB operator installation with retry logic and github repos#536
Open
elfosardo wants to merge 1 commit intometal3-io:mainfrom
Open
🌱 Update MariaDB operator installation with retry logic and github repos#536elfosardo wants to merge 1 commit intometal3-io:mainfrom
elfosardo wants to merge 1 commit intometal3-io:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
metal3-io-bot
added
the
size/M
Update the MariaDB operator installation process in test/prepare.sh to improve reliability: - Change repository URL to the official GitHub repository - Add helm repo update command to ensure latest chart metadata - Implement retry logic (5 attempts with 10s delays) for both CRD and operator installations to handle transient failures Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
elfosardo
force-pushed
the
prepare-test-mariadb-retries
branch
from
c061bda to
6fedd91
Compare
tuminoid
reviewed
Feb 5, 2026
Member
tuminoid
left a comment
tuminoid
left a comment
There was a problem hiding this comment.
It is easier for bots etc to detect fatal failures with ERROR.
| echo "Attempt $i failed, retrying in 10s..." | ||
| sleep 10 | ||
|
|
||
| if [ "$i" -eq 5 ]; then |
Member
There was a problem hiding this comment.
Suggested change
| if [ "$i" -eq 5 ]; then | |
| if [[ "$i" -eq 5 ]]; then |
| echo "Attempt $i failed, retrying in 10s..." | ||
| sleep 10 | ||
|
|
||
| if [ "$i" -eq 5 ]; then |
Member
There was a problem hiding this comment.
Suggested change
| if [ "$i" -eq 5 ]; then | |
| if [[ "$i" -eq 5 ]]; then |
| sleep 10 | ||
|
|
||
| if [ "$i" -eq 5 ]; then | ||
| echo "Failed to install MariaDB Operator after 5 attempts." |
Member
There was a problem hiding this comment.
Suggested change
| echo "Failed to install MariaDB Operator after 5 attempts." | |
| echo "ERROR: Failed to install MariaDB Operator after 5 attempts." |
| sleep 10 | ||
|
|
||
| if [ "$i" -eq 5 ]; then | ||
| echo "Failed to install MariaDB CRDs after 5 attempts." |
Member
There was a problem hiding this comment.
Suggested change
| echo "Failed to install MariaDB CRDs after 5 attempts." | |
| echo "ERROR: Failed to install MariaDB CRDs after 5 attempts." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the MariaDB operator installation process in test/prepare.sh to improve reliability: