Support annotations for imported entities #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to allow imports (which have no revision) to have annotations, we have to make `annotation.last_revision_id` nullable in the schema and in the code of `bookbrainz-site`.
kellnerd
commented
Jul 17, 2024
MonkeyDo
added a commit
to metabrainz/bookbrainz-site
that referenced
this pull request
Jul 17, 2024
Relict from metabrainz/bookbrainz-site#448 which was abandoned in metabrainz/bookbrainz-site#450 These validation functions were not even covered by unit tests.
MonkeyDo
reviewed
Jul 17, 2024
MonkeyDo
added a commit
to metabrainz/bookbrainz-site
that referenced
this pull request
Jul 17, 2024
This was referenced Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Annotations are not implemented for imported entities, because they have a
last_revision_id INT NOT NULLcolumn. Since an import does not have a revision, it is not possible to create a valid annotation row for it.Solution
Actually use the given annotation data from the queued entity and insert it into the database with
last_revision_id = NULL.Before this code is usable, we have to make
annotation.last_revision_idnullable in the schema andin the code of
bookbrainz-site.P.S. Also sneaking in a minor DX QoL change with a032186.