Fix CI and open telemetry API usage#305
Closed
H-Huang wants to merge 4 commits intometa-pytorch:mainfrom
Closed
Conversation
meta-cla
bot
added
the
CLA Signed
H-Huang
changed the title
tianyu-l
approved these changes
Dec 23, 2025
tianyu-l
left a comment
tianyu-l
left a comment
There was a problem hiding this comment.
There seem to be other failures.
Stamp to unblock -- hope that's OK
Contributor
Author
|
CPU tests are passing now, but the GPU tests are failing with a NCCL error (https://github.com/meta-pytorch/torchft/actions/runs/20466340171/job/58826912036?pr=305) that is unrelated to the PR. I will land it and we should investigate where the nccl error is happening |
H-Huang
added a commit
to H-Huang/torchft
that referenced
this pull request
Dec 26, 2025
Summary: TorchFT CI is installing the latest `opentelemetry-sdk`, which caused breakages in some of the APIs in otel.py. This PR updates `otel.py` to use the correct APIs. This PR also fixes TorchFT lint (pyre check was failing). This should resolve the failing TorchFT CI failures: https://github.com/meta-pytorch/torchft/actions/runs/19983176027/job/57313269930 This is also causing downstream CI failures in in torchtitan: https://github.com/pytorch/torchtitan/actions/workflows/integration_test_8gpu_torchft.yaml Reviewed By: tianyu-l Differential Revision: D89743414 Pulled By: H-Huang
AnantGulati
pushed a commit
to AnantGulati/torchft
that referenced
this pull request
Jan 2, 2026
Summary: Pull Request resolved: meta-pytorch#306 TorchFT CI is installing the latest `opentelemetry-sdk`, which caused breakages in some of the APIs in otel.py. This PR updates `otel.py` to use the correct APIs. This PR also fixes TorchFT lint (pyre check was failing). This should resolve the failing TorchFT CI failures: https://github.com/meta-pytorch/torchft/actions/runs/19983176027/job/57313269930 This is also causing downstream CI failures in in torchtitan: https://github.com/pytorch/torchtitan/actions/workflows/integration_test_8gpu_torchft.yaml Pull Request resolved: meta-pytorch#305 Reviewed By: tianyu-l Differential Revision: D89743414 Pulled By: H-Huang fbshipit-source-id: c066fe535b332ba94b918f5b684595c8de8b6740
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TorchFT CI is installing the latest
opentelemetry-sdk, which caused breakages in some of the APIs in otel.py. This PR updatesotel.pyto use the correct APIs.This PR also fixes TorchFT lint (pyre check was failing).
This should resolve the failing TorchFT CI failures:
https://github.com/meta-pytorch/torchft/actions/runs/19983176027/job/57313269930
This is also causing downstream CI failures in in torchtitan: https://github.com/pytorch/torchtitan/actions/workflows/integration_test_8gpu_torchft.yaml