fix broken test test_actor_mesh_stop_timeout#3350
Open
pzhan9 wants to merge 1 commit intometa-pytorch:mainfrom
Open
fix broken test test_actor_mesh_stop_timeout#3350pzhan9 wants to merge 1 commit intometa-pytorch:mainfrom
pzhan9 wants to merge 1 commit intometa-pytorch:mainfrom
Conversation
Summary: This test start to fail after D96760759: ``` thread '<unnamed>' (27024) panicked at fbcode/monarch/hyperactor_mesh/src/actor_mesh.rs:1555:9: Stop took 5.137553ms, expected >= 900ms (should have waited for timeout) stack backtrace: ``` I think this is because D96760759: > sends a stop signal to the proc without waiting for termination (callers never used the result). which make the time spent on stop getting much shorter. I do not get why this test need to assert on `>900ms`. The comment in the code did not explain that either. Remove it. Differential Revision: D99285980
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This test start to fail after D96760759:
I think this is because D96760759:
which make the time spent on stop getting much shorter.
I do not get why this test need to assert on
>900ms. The comment in the code did not explain that either. Remove it.Differential Revision: D99285980