Skip to content

Fix missing fields in MacOS build#3344

Open
mkuchnik wants to merge 2 commits intometa-pytorch:mainfrom
mkuchnik:mkuchnik/macos_build_fix
Open

Fix missing fields in MacOS build#3344
mkuchnik wants to merge 2 commits intometa-pytorch:mainfrom
mkuchnik:mkuchnik/macos_build_fix

Conversation

@mkuchnik
Copy link
Copy Markdown
Contributor

@mkuchnik mkuchnik commented Apr 1, 2026

MacOS has additional file fields that cause the build to fail:

      error[E0063]: missing fields `crtime` and `flags` in initializer of `fuse3::path::reply::FileAttr`
         --> monarch_extension/src/readonly_fuse.rs:375:24
          |
      375 |             .unwrap_or(FileAttr {
          |                        ^^^^^^^^ missing `crtime` and `flags`

      error[E0063]: missing fields `crtime` and `flags` in initializer of `fuse3::path::reply::FileAttr`
         --> monarch_extension/src/readonly_fuse.rs:161:8
          |
      161 |     Ok(FileAttr {
          |        ^^^^^^^^ missing `crtime` and `flags`

      error[E0063]: missing fields `crtime` and `flags` in initializer of `fuse3::path::reply::FileAttr`
         --> monarch_extension/src/chunked_fuse.rs:173:8
          |
      173 |     Ok(FileAttr {
          |        ^^^^^^^^ missing `crtime` and `flags`

      For more information about this error, try `rustc --explain E0063`.

on v0.4.0 this is:

 error[E0063]: missing fields `crtime` and `flags` in initializer of
      `fuse3::path::reply::FileAttr`
        --> monarch_extension/src/chunked_fuse.rs:83:8
         |
      83 |     Ok(FileAttr {
         |        ^^^^^^^^ missing `crtime` and `flags`

      For more information about this error, try `rustc --explain E0063`.

The first commit was tested on top of v0.4.0 (and thus can be cherry-picked into the tagged v0.4.0). The second was necessary on top of main. All changes are guarded on MacOS builds so no behavior should change for other platforms.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 1, 2026
@mkuchnik mkuchnik requested a review from cpuhrsch April 1, 2026 21:17
This diff adds `crtime` and `flags` in chunked_fuse.rs.
These are missing fields on MacOS that result in compile errors.
@mkuchnik mkuchnik force-pushed the mkuchnik/macos_build_fix branch from 4492c63 to d5361d9 Compare April 2, 2026 15:44
This diff adds `crtime` and `flags` in reasonly_fuse.rs (on v0.5.0
development).
These are missing fields on MacOS that result in compile errors.
@mkuchnik mkuchnik force-pushed the mkuchnik/macos_build_fix branch from d5361d9 to 94070c9 Compare April 2, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant