Fix missing fields in MacOS build#3344
Open
mkuchnik wants to merge 2 commits intometa-pytorch:mainfrom
Open
Conversation
This diff adds `crtime` and `flags` in chunked_fuse.rs. These are missing fields on MacOS that result in compile errors.
4492c63 to
d5361d9
Compare
This diff adds `crtime` and `flags` in reasonly_fuse.rs (on v0.5.0 development). These are missing fields on MacOS that result in compile errors.
d5361d9 to
94070c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MacOS has additional file fields that cause the build to fail:
on v0.4.0 this is:
The first commit was tested on top of v0.4.0 (and thus can be cherry-picked into the tagged v0.4.0). The second was necessary on top of main. All changes are guarded on MacOS builds so no behavior should change for other platforms.