GRAFTED: .scoped_state() in Job, Split of "WAR: poll_for, plus some test disables, green OSS CI"#3214
Open
mariusae wants to merge 1 commit intogh/mariusae/325/basefrom
Open
GRAFTED: .scoped_state() in Job, Split of "WAR: poll_for, plus some test disables, green OSS CI"#3214mariusae wants to merge 1 commit intogh/mariusae/325/basefrom
mariusae wants to merge 1 commit intogh/mariusae/325/basefrom
Conversation
…est disables, green OSS CI" add a context manager so that with `job.scoped_state() as state:` gives you the job state but then kills the job when the job finishes. Use it in the tests so that we no longer spawn a bunch of procs that are never cleaned up.. Differential Revision: [D98197943](https://our.internmc.facebook.com/intern/diff/D98197943/) [ghstack-poisoned]
meta-cla
bot
added
the
CLA Signed
This was referenced Mar 25, 2026
This was referenced Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
add a context manager so that with
job.scoped_state() as state:gives you the job state but then kills the job when the job finishes. Use it in the tests so that we no longer spawn a bunch of procs that are never cleaned up..Differential Revision: D98197943