Skip to content

Conversation

@VivekSil
Copy link

@VivekSil VivekSil commented Oct 27, 2025

This PR will add Maze environment (#105)

Specifications:

  • The maze can be specified by the user with start and exit points as a numpy array.
  • Current default maze is of size 8x8 with start and exit cells being (0,0) and (7,7) respectively.

Reward setting:

  • reward_exit: Reward for reaching the exit cell
  • reward_move: Reward for a move that didn't find the exit but is valid
  • penalty_visited: penalty for revisiting a cell
  • penalty_impossible: penalty for invalid move (wall/outside)

@meta-cla
Copy link

meta-cla bot commented Oct 27, 2025

Hi @VivekSil!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@VivekSil VivekSil marked this pull request as draft October 27, 2025 18:42
@meta-cla
Copy link

meta-cla bot commented Oct 27, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 27, 2025
@VivekSil VivekSil marked this pull request as ready for review October 27, 2025 18:54
@init27 init27 requested a review from Copilot November 1, 2025 03:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR integrates a Maze game environment with the OpenEnv framework, providing both server-side and client-side implementations with Docker support.

  • Implements MazeEnvironment wrapper that exposes the Maze game through OpenEnv's Environment interface
  • Adds HTTP client and server infrastructure for remote maze environment interaction
  • Includes example scripts demonstrating both automated and human-interactive maze solving

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 15 comments.

Show a summary per file
File Description
src/envs/maze_env/server/mazearray.py Defines the maze layout as a numpy array
src/envs/maze_env/server/maze_environment.py Wraps Maze game to implement OpenEnv Environment interface
src/envs/maze_env/server/maze.py Core Maze implementation with coordinate system (col, row)
src/envs/maze_env/server/app.py FastAPI application exposing maze environment over HTTP
src/envs/maze_env/server/init.py Package exports for server components
src/envs/maze_env/server/Dockerfile Container configuration for maze environment server
src/envs/maze_env/models.py Data models for actions, observations, and state
src/envs/maze_env/client.py HTTP client for connecting to maze environment server
src/envs/maze_env/init.py Package exports for client components
src/envs/maze_env/README.md Documentation for maze environment usage
examples/maze_simple.py Example demonstrating automated maze navigation
examples/maze_human.py Example demonstrating human-interactive maze solving
.github/workflows/docker-build.yml Adds maze-env to CI/CD Docker build workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

✅ Deployment succeeded for maze_env

Nice work! Wait for a code review and we're ready to go.

You can iterate locally or validate fixes by running scripts/deploy_to_hf.sh --env "maze_env".

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 2, 2025

✅ Deployment succeeded for maze_env

Nice work! Wait for a code review and we're ready to go.

You can iterate locally or validate fixes by running scripts/deploy_to_hf.sh --env "maze_env".

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

✅ Deployment succeeded for maze_env

Nice work! Wait for a code review and we're ready to go.

You can iterate locally or validate fixes by running scripts/deploy_to_hf.sh --env "maze_env".

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

✅ Deployment succeeded for maze_env

Nice work! Wait for a code review and we're ready to go.

You can iterate locally or validate fixes by running scripts/deploy_to_hf.sh --env "maze_env".

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

✅ Deployment succeeded for maze_env

Nice work! Wait for a code review and we're ready to go.

You can iterate locally or validate fixes by running scripts/deploy_to_hf.sh --env "maze_env".

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

✅ Deployment succeeded for maze_env

Nice work! Wait for a code review and we're ready to go.

You can iterate locally or validate fixes by running scripts/deploy_to_hf.sh --env "maze_env".

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

✅ Deployment succeeded for maze_env

Nice work! Wait for a code review and we're ready to go.

You can iterate locally or validate fixes by running scripts/deploy_to_hf.sh --env "maze_env".

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

✅ Deployment succeeded for maze_env

Nice work! Wait for a code review and we're ready to go.

You can iterate locally or validate fixes by running scripts/deploy_to_hf.sh --env "maze_env".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant