-
Notifications
You must be signed in to change notification settings - Fork 88
Add maze environment and example #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @VivekSil! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR integrates a Maze game environment with the OpenEnv framework, providing both server-side and client-side implementations with Docker support.
- Implements MazeEnvironment wrapper that exposes the Maze game through OpenEnv's Environment interface
- Adds HTTP client and server infrastructure for remote maze environment interaction
- Includes example scripts demonstrating both automated and human-interactive maze solving
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| src/envs/maze_env/server/mazearray.py | Defines the maze layout as a numpy array |
| src/envs/maze_env/server/maze_environment.py | Wraps Maze game to implement OpenEnv Environment interface |
| src/envs/maze_env/server/maze.py | Core Maze implementation with coordinate system (col, row) |
| src/envs/maze_env/server/app.py | FastAPI application exposing maze environment over HTTP |
| src/envs/maze_env/server/init.py | Package exports for server components |
| src/envs/maze_env/server/Dockerfile | Container configuration for maze environment server |
| src/envs/maze_env/models.py | Data models for actions, observations, and state |
| src/envs/maze_env/client.py | HTTP client for connecting to maze environment server |
| src/envs/maze_env/init.py | Package exports for client components |
| src/envs/maze_env/README.md | Documentation for maze environment usage |
| examples/maze_simple.py | Example demonstrating automated maze navigation |
| examples/maze_human.py | Example demonstrating human-interactive maze solving |
| .github/workflows/docker-build.yml | Adds maze-env to CI/CD Docker build workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
✅ Deployment succeeded for
Nice work! Wait for a code review and we're ready to go. You can iterate locally or validate fixes by running |
1 similar comment
|
✅ Deployment succeeded for
Nice work! Wait for a code review and we're ready to go. You can iterate locally or validate fixes by running |
|
✅ Deployment succeeded for
Nice work! Wait for a code review and we're ready to go. You can iterate locally or validate fixes by running |
|
✅ Deployment succeeded for
Nice work! Wait for a code review and we're ready to go. You can iterate locally or validate fixes by running |
|
✅ Deployment succeeded for
Nice work! Wait for a code review and we're ready to go. You can iterate locally or validate fixes by running |
|
✅ Deployment succeeded for
Nice work! Wait for a code review and we're ready to go. You can iterate locally or validate fixes by running |
|
✅ Deployment succeeded for
Nice work! Wait for a code review and we're ready to go. You can iterate locally or validate fixes by running |
|
✅ Deployment succeeded for
Nice work! Wait for a code review and we're ready to go. You can iterate locally or validate fixes by running |
This PR will add Maze environment (#105)
Specifications:
Reward setting: