Fix test_compiler_detection relation to missing/broken compilers #14661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm that this patch on top of 1.8.1 fixes the test in question on ELN (the future RHEL 11), where gcc is the default compiler and ObjC is disabled. |
dcbaker
force-pushed
the
submit/fix-objc-detection
branch
from
da7db7a to
a07c18c
Compare
eli-schwartz
reviewed
Jun 5, 2025
Which is a very large and complicated test function
dcbaker
force-pushed
the
submit/fix-objc-detection
branch
from
a07c18c to
9e4294f
Compare
Add a few asserts for functions that could in theory return None, but if they do something has gone *really* wrong with the test.
This wraps all of the compiler detections in this test case in try/except blocks. These blocks will return a skipTest for Python >= 3.11 (where subTest and skipTest interact correctly), and continue if they do not. For Meson CI runs they will fail the specific subtest, which is also an improvement as it can help pinpoint exactly which subtest failed. Fixes: mesonbuild#14579
dcbaker
force-pushed
the
submit/fix-objc-detection
branch
from
9e4294f to
e297fa7
Compare
eli-schwartz
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.