Added a notes field to Dynamic form informing users about BLE and Wifi use #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…users about using BLE and wifi at the same time.
|
If you could revert the changes to |
|
I've resolved the merge conflict ensuring I accept the changes from master. Should be ready to merge. I have access to merge this code but was waiting for a review of it. |
Hunter275
approved these changes
Mar 1, 2025
KomelT
approved these changes
Mar 1, 2025
fifieldt
approved these changes
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change was made so users can be informed that on some device (ESP32) they cant enable Wifi and BLE at the samew time, since this is device specific it was a straight forward change adding a note, at a later time we can have device specific warnings enabled.
Changes Made
Testing Done
Tests are prerequisite of this PR
Screenshots (if applicable)
Checklist
Additional Notes