Skip to content

enhancement(mesh): remove late packets from tx queue when full #9779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thebentern merged 3 commits into from
Feb 28, 2026
Merged

enhancement(mesh): remove late packets from tx queue when full #9779

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ce0c20
enhance tx queue priority management
m1nl Feb 28, 2026
5ac8e27
Merge branch 'develop' into enhance_tx_queue_management
thebentern Feb 28, 2026
d769cff
apply copilot recommendation for cast
m1nl Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/mesh/MeshPacketQueue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,28 @@ bool MeshPacketQueue::replaceLowerPriorityPacket(meshtastic_MeshPacket *p)
}
}

if (backPacket->tx_after) {
// Check if there's a late packet at the queue end
auto now = millis();
if (backPacket->tx_after < now && (!p->tx_after || backPacket->tx_after > p->tx_after)) {
if (p->tx_after) {
LOG_WARN("Dropping late packet 0x%08x with TX delay %dms to make room in the TX queue for packet 0x%08x with "
"TX delay %ums",
backPacket->id, backPacket->tx_after - now, p->id, p->tx_after - now);

} else {
LOG_WARN("Dropping late packet 0x%08x with TX delay %dms to make room in the TX queue for packet 0x%08x "
"with no TX delay",
backPacket->id, backPacket->tx_after - now, p->id);
}
queue.pop_back();
packetPool.release(backPacket);
// Insert the new packet in the correct order
enqueue(p);
return true;
}
}

// If the back packet's priority is not lower, no replacement occurs
return false;
}
Loading