Skip to content

Don't launch canned message when waking screen or silencing notification#9762

Merged
jp-bennett merged 4 commits intodevelopfrom
jp-bennett-patch-1
Feb 27, 2026
Merged

Don't launch canned message when waking screen or silencing notification#9762
jp-bennett merged 4 commits intodevelopfrom
jp-bennett-patch-1

Conversation

@jp-bennett
Copy link
Collaborator

Particularly devices with keyboards have an obnoxious behavior, where pressing a key to silence the notification or wake the screen will launch canned messages. This change ignores that first keystroke.

@github-actions github-actions bot added needs-review Needs human review bugfix Pull request that fixes bugs labels Feb 26, 2026
@thebentern thebentern requested a review from Copilot February 26, 2026 17:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prevents the “wake/silence” keystroke from being treated as an actionable input (e.g., launching canned messages), which is especially disruptive on keyboard-equipped devices.

Changes:

  • Detect whether the screen was off at the moment an input arrives; if so, wake the device but drop that input event.
  • When an external notification is actively nagging, stop it and consume the input event so it doesn’t propagate to other input handlers.

@jp-bennett jp-bennett merged commit 857c7b3 into develop Feb 27, 2026
75 of 77 checks passed
@jp-bennett jp-bennett deleted the jp-bennett-patch-1 branch February 27, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes bugs needs-review Needs human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants