Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added validation to the Community Newsletter form #1977

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

aakankshabhende
Copy link
Member

Description
Added validation to the Community Newsletter form, the first name and last name should accept alphabetical input only.

This PR fixes #1974

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Copy link

welcome bot commented Dec 3, 2024

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for mesheryio-preview failed.

Name Link
🔨 Latest commit ca3443e
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/67768f9c434693000839903a

@vishalvivekm
Copy link
Contributor

@aakankshabhende
Let's discuss this on websites call on Monday at 6:30 PM IST (7:00 AM CT). Add it as an agenda item to the meeting minutes, if you would :)

@leecalcote
Copy link
Member

@aakankshabhende thanks for this. Are we ready for review here or still in-draft?

@aakankshabhende
Copy link
Member Author

Yes, its still in draft, I'll send a fix for styling and minimum length requirement and make it ready to review.

Signed-off-by: aakankshabhende <[email protected]>
Signed-off-by: aakankshabhende <[email protected]>
@aakankshabhende aakankshabhende marked this pull request as ready for review December 16, 2024 10:40
@leecalcote
Copy link
Member

@Venkata-Sai-Vishwanath-robo would you like to offer review on this PR?

@Venkata-Sai-Vishwanath-robo
Copy link
Contributor

Venkata-Sai-Vishwanath-robo commented Jan 2, 2025

@Venkata-Sai-Vishwanath-robo would you like to offer review on this PR?

Sure, @leecalcote! I would love to take it on. I’ll do my best to provide helpful feedback and appreciate your understanding as I learn through this process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need validation for the Community Newsletter form
4 participants