-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert-breaking-changes #1511
revert-breaking-changes #1511
Conversation
Signed-off-by: vishalvivekm <[email protected]>
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@vishalvivekm its still breaking |
The page loads and reloads and then crashes |
Also, this is how it looks in IOS device before this PR i.e #1185 was merged |
Thanks for confirming @GaganpreetKaurKalsi @iArchitSharma, we now know that we hafta start with the #1186 and that it was indeed the first pr with crashing catalog page. |
The pr #1186 included Visibility of cards for All option on mobile and a View All button. One of the solution I got for this is error: |
Signed-off-by: vishalvivekm <[email protected]>
Is this PR needed any longer? |
It's not. Closing. |
Description
Meshery.io/catalog is crashing in iOS safari and the first PR that seems to be having this turns out to be : #1186
This PR reverts changes done in 1186 to no avail.
screencast from BroswerStack iphone 12 pro:
iPhone.12.Pro.v14.4.-.Google.Chrome.2023-12-07.12-41-02.mp4
Notes for Reviewers
Signed commits