Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]:Changing Upload and download artifact actions to v4 #690

Merged
merged 13 commits into from
Jan 16, 2025
Merged

[WIP]:Changing Upload and download artifact actions to v4 #690

merged 13 commits into from
Jan 16, 2025

Conversation

TusharMohapatra07
Copy link
Contributor

Description

This PR is a part of meshery/meshery#12868

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@TusharMohapatra07
bump upload-arifact to v4
d16f96e 
Signed-off-by: TusharMohapatra07 <[email protected]>
@welcome Welcome
Copy link

welcome bot commented Dec 11, 2024

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@TusharMohapatra07 TusharMohapatra07 changed the title [WIP]:Changing Upload artifact actions to v4 [WIP]:Changing Upload and download artifact actions to v4 Dec 11, 2024
@TusharMohapatra07
change file name to data.json
c14fb05 
Signed-off-by: TusharMohapatra07 <[email protected]>
@leecalcote leecalcote requested a review from jerensl December 11, 2024 13:22
@leecalcote leecalcote added kind/chore Necessary task area/ci Continuous integration | Build and release labels Dec 11, 2024
@TusharMohapatra07
Copy link
Contributor Author

Hey maintainers,
image
I'm facing this issue, i've also read the faqs and rules but still this is failing, am i doing something wrong here ?
I'm kinda stuck

@devhindo
Copy link
Member

devhindo commented Dec 14, 2024 •
edited
Loading

which action is causing this error? provide url of the logs

@TusharMohapatra07
Copy link
Contributor Author

@devhindo https://github.com/TusharMohapatra07/meshery-istio/actions/runs/12272484785

@TusharMohapatra07
Revert "fix unexpected symbol issue"
c5d113f 
This reverts commit 3d6bb3d.

Signed-off-by: TusharMohapatra07 <[email protected]>
@TusharMohapatra07
remove path
906a41a 
Signed-off-by: TusharMohapatra07 <[email protected]>
@TusharMohapatra07
test: checking if this works
f911ece 
Signed-off-by: TusharMohapatra07 <[email protected]>
@TusharMohapatra07
test: checking if this works
1438b19 
Signed-off-by: TusharMohapatra07 <[email protected]>
@TusharMohapatra07
test commit
eb89784 
Signed-off-by: TusharMohapatra07 <[email protected]>
leecalcote
leecalcote approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@leecalcote leecalcote merged commit ec50a11 into meshery:master Jan 16, 2025
1 check passed
@welcome Welcome
Copy link

welcome bot commented Jan 16, 2025

Thanks for your contribution to the Meshery! 🎉

Meshery Celebration logo
        Join the community, if you haven't yet and please leave a ⭐ star on the project. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote approved these changes

@jerensl jerensl Awaiting requested review from jerensl

Assignees
No one assigned
Labels
area/ci Continuous integration | Build and release kind/chore Necessary task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TusharMohapatra07 @devhindo @leecalcote