-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub Actions workflows to use setup-go@v5 and golangci-lint-action@v6; refactor error formatting and import statements #173
Conversation
…action@v6; refactor error formatting and import statements Signed-off-by: devhindo <[email protected]>
Signed-off-by: devhindo <[email protected]>
Signed-off-by: devhindo <[email protected]>
Signed-off-by: devhindo <[email protected]>
Signed-off-by: devhindo <[email protected]>
…[email protected] with latest version Signed-off-by: devhindo <[email protected]>
…m register.go Signed-off-by: devhindo <[email protected]>
Signed-off-by: devhindo <[email protected]>
all tests are passing now except for this issue! meshery/meshery#13024 @leecalcote |
an opinion about the mentioned issue would be really helpful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
This PR also fixes this ancient GH issue: #151 👏🙌 |
In my opinion, all E2E workflow are failing because the pattern file that is being used to deploy the mesh is of former OAM type and doesn't follows the new MeshModel schema due to which Meshery server is unable to ingest the sample design (a step done before passing it on to the Service Mesh Adapter for deployment) and hence the subsequent assertions that are made in workflow fails. This error message confirms that pattern apply failed https://github.com/meshery/meshery-cilium/actions/runs/12528133889/job/34942427822?pr=173#step:17:14 Also, the status of all resources in K8s here https://github.com/meshery/meshery-cilium/actions/runs/12528133889/job/34942427822#step:22:1 confirms that the service mesh didn't come up. If we can update these pattern files https://github.com/meshery/meshery-cilium/blob/master/.github/install/deploy.yaml based on the Meshery Design schema then we should be able to fix the issue. |
Signed-off-by: devhindo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
fixes issues with existing code
edit: solves: #151