Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting, pre-commit, and CI #158

Closed
wants to merge 1 commit into from

Conversation

jiuguangw
Copy link

@jiuguangw jiuguangw commented Dec 8, 2023

This PR provides several infrastructure related improvements to Meshcat, primarily in the form of a linter, according to the JavaScript Standard Style. A bulk of the linter errors have been addressed already, with the exception of the following (disabled via comment in src/index.js):

  • camelcase
  • eqeqeq
  • no-undef
  • no-eval
  • no-redeclare
  • no-var
  • no-unused-expressions

In addition,

  • Add pre-commit hook for the linter, which can be run by pre-commit run --all-files
  • Add a GitHub Actions workflow to enforce pre-commit (triggered on PR and push to master)
  • Update .gitignore
  • Update Readme

Please note that GitHub repos have a setting called "run workflows from fork pull requests" - it seems that this is disabled right now, which is why the CI is not triggering. The CI result from my fork can be found here.

* Add pre-commit and fix style errors
* Add CI to enforce pre-commit
* Update .gitignore
* Update Readme
@jiuguangw
Copy link
Author

@RussTedrake , just tagging you on this PR in advance of our meeting tomorrow.

@RussTedrake
Copy link
Collaborator

Will close this one due to lack of activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants