Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #97. See discussion there.
Opening this to discuss/debug more easily.
Ideally we'd mark tests with mpi-pytest's
parallel
marker: for example, a test marked withparallel(nprocs=[1, 2, 3])
would be run in serial, as well as with 2 and 3 processes in parallel. But passing multiple values tonprocs
like this doesn't seem to work forunittest
-based tests. So here I have a workaround, where I mark tests with a newparallel_dynamic
marker, which then gets replaced byparallel(nprocs=N)
, whereN
is whatever is passed tompiexec -n N
. This works well, but it's probably better to be explicit, so it's just a temporary solution.