-
Notifications
You must be signed in to change notification settings - Fork 49
GitHub CI Workflow Enhancements Part 5 #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub CI Workflow Enhancements Part 5 #403
Conversation
…er optimizations (-O3 => -O2).
|
Notes on the 3 gradient tests failing (both serial & MPI versions):
|
…iminate global namespace exceeded warnings for oneAPI builds. Rename modules for consistency (open/closed shell).
|
Failing test issues have been resolved, so this is now ready for review. |
agoetz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. All serial and mpi tests of the full CPU test suite including f functions pass using oneAPI 2025.0.4.
We will have to address the limitations wrt bundled BLAS/LAPACK. At the very least document that cmake flags -DMKL_HOME=$MKLROOT -DMKL_MULTI_THREADED=FALSE are required.
NOTE: do not merge this until the 3 gradient tests failures described below are fixed.NOTE: the branch in the PR is based off of the work in #402, so merge that PR first before merging this work.
This PR adds support for building QUICK with the Intel oneAPI compilers (CMake via the
-DCOMPILER=INTELLLVMkeyword). Also Github CI tests for Intel oneAPI builds are added for the following runners:CMake builds:
Notes / Limitations:
-ipoFortran flag due to related issues with interprocedural optimization for libraries).Closes #327.