Fix/mm2 1318: Typescript errors pt 3 #205
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…typescript-errors-pt-3
mikolvj
changed the base branch from
test
to
fix/mm2-1280/typescript-errors-pt-2
src/hooks/api/products.tsx
Outdated
| const limitedProducts = filter?.limit | ||
| ? products.slice(0, filter.limit) | ||
| : products | ||
|
|
||
| return { | ||
| ...data, | ||
| products: productsImagesFormatter(products?.slice(0, filter?.limit)) || [], | ||
| products: limitedProducts, |
There was a problem hiding this comment.
we're going to remove FE filtering, soon this will be unused
There was a problem hiding this comment.
not sure if we need this on main branch
fix-typescript-errors-v2.plan.md
Outdated
There was a problem hiding this comment.
not sure if we need this on main branch
scripts/ts-check.js
Outdated
There was a problem hiding this comment.
not sure if we need this on main branch
| } | ||
| ) | ||
|
|
||
| console.log(products,'products') |
| const processedProducts = products?.slice(offset, offset + PAGE_SIZE) || [] | ||
| const processedCount = | ||
| count < (products?.length || 0) ? count : products?.length || 0 |
There was a problem hiding this comment.
you can remove this after Alan's pr is merged
| ? regionsCurrencyMap[regionId as string] | ||
| : currencyCodeOrRegionId | ||
|
|
||
| let existingId: string | undefined = undefined |
There was a problem hiding this comment.
pls don't define anything as undefined
| return | ||
| } | ||
|
|
||
| // Create a clean payload for the API |
| </RouteDrawer.Header> | ||
| {!isLoading && product && ( | ||
| <ProductShippingProfileForm product={product} /> | ||
| <ProductShippingProfileForm product={product as any} /> |
There was a problem hiding this comment.
Removed as any
| } | ||
|
|
||
| function productsImagesFormatter( | ||
| products: ExtendedAdminProduct[] | ExtendedAdminProduct | undefined |
There was a problem hiding this comment.
how about
products?: ExtendedAdminProduct[] | ExtendedAdminProduct
sylwia-werner
changed the base branch from
fix/mm2-1280/typescript-errors-pt-2
to
test
sylwia-werner
dismissed
mikolvj’s stale review
The merge-base changed after approval.
Fix pt-3
MM2-1318