Fix/mm2 1280/typescript errors pt 2 #194
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
src/hooks/api/price-lists.tsx
Outdated
| const price_lists: ExtendedPriceList[] | undefined = data?.price_lists | ||
| ?.filter((item) => item.price_list) | ||
| .map((item) => ({ | ||
| ...item.price_list, | ||
| id: item.price_list.id, | ||
| })) | ||
|
|
There was a problem hiding this comment.
how about:
const price_lists: ExtendedPriceList[] = (data?.price_lists || []) .filter((item) => item.price_list) .map((item) => ({ ...item.price_list, id: item.price_list.id, }))
src/lib/addresses.ts
Outdated
| // Check if it's an AdminOrderAddress (has first_name/last_name) | ||
| const first_name = 'first_name' in address ? address.first_name : undefined | ||
| const last_name = 'last_name' in address ? address.last_name : undefined | ||
| const country = 'country' in address ? address.country : undefined | ||
|
|
There was a problem hiding this comment.
please remove the comment and how about just:
const first_name = address?.first_name
const last_name = address?.last_name
const country = address?.country
There was a problem hiding this comment.
address can be HttpTypes.AdminOrderAddress | HttpTypes.AdminStockLocationAddress and those properties don't exist on HttpTypes.AdminStockLocationAddress. That's why I left the comment but will be removed 👍
There was a problem hiding this comment.
right, got it
but still, how about shortening those consts to
const first_name = address?.first_name const last_name = address?.last_name const country = address?.country
result should be the same -> if there is the key (eg. first_name) should return it, else should be set to undefined
| return `/customer-groups/${row.original.customer_group_id}` | ||
| }} | ||
| getRowId={(row) => row.customer_group_id} | ||
| // For some reason the table requires accessing data on row.original in this specific case |
There was a problem hiding this comment.
imo this comment is unnecessary
There was a problem hiding this comment.
With this comment I explained why I used any :D but the rows are fixed in pt-3 or pt-4, removing the comment
| cell: ({ getValue }) => { | ||
| const locationName = getValue() | ||
| cell: ({ row }) => { | ||
| const locationName = row.original.stock_locations?.[0]?.name |
There was a problem hiding this comment.
wondering if this array always has just 1 element, what do you think about mapping the array in cell? if somehow there will be more values, all of them will be displayed
There was a problem hiding this comment.
There should be just one element, but I can map it just in case
| }).join(", ")} | ||
| next={getFormattedAddress({ | ||
| address: update.actions[0].details.new, | ||
| address: update?.actions[0]?.details?.new, |
There was a problem hiding this comment.
not sure if we should allow to pass empty addresses here
There was a problem hiding this comment.
If there's no address for some reason, it just won't be displayed, getFormattedAddress and ChangeDetailsTooltip handle this case
| shouldDirty: true, | ||
| }) | ||
| form.setValue(`enabled_rules.${type}`, false, { | ||
| form.setValue(`enabled_rules.${type}` as "enabled_rules.product" | "enabled_rules.product_type", false, { |
There was a problem hiding this comment.
if we need this casting, i guess we can use sth like this
enabled_rules.${type as "product" | "product_type"}
There was a problem hiding this comment.
These are different fields and they need this casting exactly, there's schema with both enabled_rules.product, enabled_rules.product_type and product, product_type
|
|
||
| const enableRule = (type: TaxRateRuleReferenceType) => { | ||
| form.setValue(`enabled_rules.${type}`, true, { | ||
| form.setValue(`enabled_rules.${type}` as "enabled_rules.product" | "enabled_rules.product_type", true, { |
There was a problem hiding this comment.
These are different fields and they need this casting exactly, there's schema with both enabled_rules.product, enabled_rules.product_type and product, product_type
| // case TaxRateRuleReferenceType.CUSTOMER_GROUP: | ||
| // return customerGroups | ||
| default: | ||
| return products // Fallback to products for unsupported types |
There was a problem hiding this comment.
please remove this comment
| shouldDirty: true, | ||
| }) | ||
| form.setValue(`enabled_rules.${type}`, false, { | ||
| form.setValue(`enabled_rules.${type}` as "enabled_rules.product" | "enabled_rules.product_type", false, { |
There was a problem hiding this comment.
These are different fields and they need this casting exactly, there's schema with both enabled_rules.product, enabled_rules.product_type and product, product_type
|
|
||
| const enableRule = (type: TaxRateRuleReferenceType) => { | ||
| form.setValue(`enabled_rules.${type}`, true, { | ||
| form.setValue(`enabled_rules.${type}` as "enabled_rules.product" | "enabled_rules.product_type", true, { |
There was a problem hiding this comment.
These are different fields and they need this casting exactly, there's schema with both enabled_rules.product, enabled_rules.product_type and product, product_type
sylwia-werner
changed the base branch from
fix/mm2-1209/fix-ts-errors
to
test
Fix pt-2
Link to ticket: MM2-1318
Note: to merge after #188 is merged