-
Notifications
You must be signed in to change notification settings - Fork 60
Fix/mm2 1209: Fix TS errors part 1 #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 17 commits
3b29f13
0b5a999
78db9c9
7284fa5
c0ab356
e3253be
30b089c
98944ed
58a82e8
d0d19ab
631c1df
c1701f2
c368eed
8e53ff4
26cfe3a
8e894dc
afd83aa
48818bf
c9f04b5
1683968
6e06d8a
5abd5e4
11678d8
174539d
227f4f1
e8e60b5
517b038
342af18
ede554f
db04f90
54c7c50
7c70e52
ecdf528
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ import * as React from "react" | |
| import { DayPicker } from "react-day-picker" | ||
|
|
||
| import { ChevronLeft, ChevronRight } from "@medusajs/icons" | ||
| import { clx } from "@medusajs/ui" | ||
| import { clx, IconButton } from "@medusajs/ui" | ||
|
|
||
| import "react-day-picker/src/style.css" | ||
|
|
||
|
|
@@ -59,18 +59,33 @@ function Calendar({ | |
| ...classNames, | ||
| }} | ||
| components={{ | ||
| PreviousMonthButton: ({ className, ...props }) => ( | ||
| <ChevronLeft | ||
| className={clx("absolute left-2 top-5", className)} | ||
| {...props} | ||
| /> | ||
| ), | ||
| NextMonthButton: ({ className, ...props }) => ( | ||
| <ChevronRight | ||
| className={clx("absolute right-2 top-5", className)} | ||
| {...props} | ||
| /> | ||
| ), | ||
| PreviousMonthButton: ({ className, ...props }) => { | ||
| const { onClick, ...rest } = props | ||
| return ( | ||
| <IconButton | ||
| className={clx("absolute left-0 top-2.5", className)} | ||
| variant="transparent" | ||
| onClick={onClick} | ||
| {...rest} | ||
| > | ||
| <ChevronLeft /> | ||
| </IconButton> | ||
| ) | ||
| }, | ||
| NextMonthButton: ({ className, ...props }) => { | ||
| const { onClick, ...rest } = props | ||
|
||
|
|
||
| return ( | ||
| <IconButton | ||
| className={clx("absolute right-0 top-2.5", className)} | ||
| variant="transparent" | ||
| onClick={onClick} | ||
| {...rest} | ||
| > | ||
| <ChevronRight /> | ||
| </IconButton> | ||
| ) | ||
| }, | ||
| }} | ||
| {...props} | ||
| /> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,7 +28,7 @@ export const createDataGridPriceColumns = < | |
| TFieldValues extends FieldValues, | ||
| >({ | ||
| currencies, | ||
| regions, | ||
| regions: _regions, | ||
|
||
| pricePreferences, | ||
| isReadyOnly, | ||
| getFieldName, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,5 +3,5 @@ import { ReactNode, Ref, RefAttributes, forwardRef } from "react" | |
| export function genericForwardRef<T, P = {}>( | ||
| render: (props: P, ref: Ref<T>) => ReactNode | ||
| ): (props: P & RefAttributes<T>) => ReactNode { | ||
| return forwardRef(render) as any | ||
| return forwardRef(render as any) as any | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please remove anys There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Leaving it for task to remove any |
||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this destructuring seems unnecessary