Suggestion around 'images' folder

- Modify the names of two `image` directories under `\python` and `\go` into `images` - Delete the unused 'image' directory under the parent directory
mercari-build · May 14, 2022 · 9d37348 · 9d37348
1 parent a652ead
commit 9d37348
Show file tree

Hide file tree

Showing 8 changed files with 4 additions and 7 deletions.
diff --git a/go/app/main.go b/go/app/main.go
@@ -13,7 +13,7 @@ import (
 )
 
 const (
-	ImgDir = "image"
+	ImgDir = "images"
 )
 
 type Response struct {
@@ -71,7 +71,7 @@ func main() {
 	// Routes
 	e.GET("/", root)
 	e.POST("/items", addItem)
-	e.GET("/image/:itemImg", getImg)
+	e.GET("/images/:itemImg", getImg)
 
 	// Start server
 	e.Logger.Fatal(e.Start(":9000"))

diff --git a/go/image/.gitignore → go/images/.gitignore b/go/image/.gitignore → go/images/.gitignore
diff --git a/go/image/default.jpg → go/images/default.jpg b/go/image/default.jpg → go/images/default.jpg
diff --git a/python/image/.gitignore b/python/image/.gitignore
diff --git a/python/image/default.jpg b/python/image/default.jpg
diff --git a/image/.gitignore → python/images/.gitignore b/image/.gitignore → python/images/.gitignore
diff --git a/image/default.jpg → python/images/default.jpg b/image/default.jpg → python/images/default.jpg
diff --git a/python/main.py b/python/main.py
@@ -8,7 +8,7 @@
 app = FastAPI()
 logger = logging.getLogger("uvicorn")
 logger.level = logging.INFO
-images = pathlib.Path(__file__).parent.resolve() / "image"
+images = pathlib.Path(__file__).parent.resolve() / "images"
 origins = [ os.environ.get('FRONT_URL', 'http://localhost:3000') ]
 app.add_middleware(
     CORSMiddleware,
@@ -39,4 +39,4 @@ async def get_image(items_image):
         logger.debug(f"Image not found: {image}")
         image = images / "default.jpg"
 
-    return FileResponse(image)
+    return FileResponse(image)