Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "GPU Acceleration" section missing after enabling Experimental Mode since version 0.5.15 #4826

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

emeric-martineau
Copy link

Describe Your Changes

Since version 0.5.15, the section GPU Acceleration in Advanced setting was remove when Experimental Mode is enable but documentation was not updated.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please help leave the screenshot as is and append your new screenshot after the original one?
as we still need to take a look at 2 places to make sure:

  1. we choose the right llamacpp
  2. we have enabled the GPU acceleration

1. Navigate to **Settings** (<Settings width={16} height={16} style={{display:"inline"}}/>) > **Advanced Settings**
2. At **GPU Acceleration**, toggle on and select your preferred GPU(s)
3. App reload is required after the selection
1. Navigate to **Settings** (<Settings width={16} height={16} style={{display:"inline"}}/>) > **Local Engine** > ** **Llama.cpp**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please help check the format here?
it looks like there are some redundant asterisks

3. Under **GPU Acceleration**, enable **Vulkan Support**
4. At **GPU Acceleration**, toggle on and select your preferred GPU(s)
5. App reload is required after the selection
1. Navigate to **Settings** (<Settings width={16} height={16} style={{display:"inline"}}/>) > **Local Engine** > ** **Llama.cpp**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please help check the format here?
it looks like there are some redundant asterisks

3. Under **GPU Acceleration**, enable **Vulkan Support**
4. At **GPU Acceleration**, toggle on and select your preferred GPU(s)
5. App reload is required after the selection
1. Navigate to **Settings** (<Settings width={16} height={16} style={{display:"inline"}}/>) > **Local Engine** > ** **Llama.cpp**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please help check the format here?
it looks like there are some redundant asterisks

1. Navigate to **Settings** (<Settings width={16} height={16} style={{display:"inline"}}/>) > **Advanced Settings**
2. At **GPU Acceleration**, toggle on and select your preferred GPU(s)
3. App reload is required after the selection
1. Navigate to **Settings** (<Settings width={16} height={16} style={{display:"inline"}}/>) > **Local Engine** > ** **Llama.cpp**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please help check the format here?
it looks like there are some redundant asterisks

@@ -259,11 +258,8 @@ AMD GPUs require **Vulkan** support.
This feature is currently experimental and must be enabled through [Experimental Mode](/docs/settings#experimental-mode) in **Advanced Settings**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to remove this as well, it's not in the Experimental mode anymore

3. Under **GPU Acceleration**, enable **Vulkan Support**
4. At **GPU Acceleration**, toggle on and select your preferred GPU(s)
5. App reload is required after the selection
1. Navigate to **Settings** (<Settings width={16} height={16} style={{display:"inline"}}/>) > **Local Engine** > ** **Llama.cpp**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please help check the format here?
it looks like there are some redundant asterisks

@@ -194,11 +190,8 @@ Intel Arc GPUs require **Vulkan** support.
This feature is currently experimental and must be enabled through [Experimental Mode](/docs/settings#experimental-mode) in **Advanced Settings**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to remove this as well, it's not in the Experimental mode anymore

1. Navigate to **Settings** (<Settings width={16} height={16} style={{display:"inline"}}/>) > **Advanced Settings**
2. At **GPU Acceleration**, toggle on and select your preferred GPU(s)
3. App reload is required after the selection
1. Navigate to **Settings** (<Settings width={16} height={16} style={{display:"inline"}}/>) > **Local Engine** > ** **Llama.cpp**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please help check the format here?
it looks like there are some redundant asterisks

@@ -156,8 +156,8 @@ Ensure you have installed all required dependencies and drivers before enabling
</Callout>

Turn on GPU acceleration to improve performance:
1. Select and **enable** your prefered GPU(s)
2. App reload is required after the selection
1. Navigate to **Settings** (<Settings width={16} height={16} style={{display:"inline"}}/>) > **Local Engine** > ** **Llama.cpp**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please help check the format here?
it looks like there are some redundant asterisks

@david-menloai
Copy link
Contributor

hi @emeric-martineau
thanks a lot for your contribution, I've left a couple of comments, could you please help take a look 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: "GPU Acceleration" section removed in v0.5.15 but the documentation is not updated
2 participants