feat: add x.com status video subtitles#1725
Conversation
🦋 Changeset detectedLatest commit: b44d3c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6509902 to
88aaff1
Compare
Contributor trust score32/100 — Moderate This score estimates contributor familiarity with Outcome
Score breakdown
Signals used
Policy
Updated automatically when the PR changes or when a maintainer reruns the workflow. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88aaff1274
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (track.mode === "disabled") { | ||
| track.mode = "hidden" | ||
| } |
There was a problem hiding this comment.
Hide showing x.com TextTracks while rendering subtitles
When the user has X's captions enabled before clicking Read Frog, the first ordered track is mode === "showing", but this branch only changes disabled tracks to hidden and leaves showing tracks rendering natively while Read Frog renders its translated/bilingual subtitles. The x.com nativeSubtitles selector is a data-read-frog-* attribute that the repo never applies, so hideNativeSubtitles() cannot suppress those browser TextTrack cues; users in that scenario get duplicated/overlapping captions until they manually turn X captions off.
Useful? React with 👍 / 👎.
88aaff1 to
b44d3c5
Compare
Summary
Verification
pnpm exec vitest run src/entrypoints/subtitles.content src/utils/subtitlespnpm exec eslint $(git status --short --untracked-files=all | awk '{print $2}' | grep -E '\\.(ts|tsx)$')pnpm exec tsc --noEmit --pretty falsegit diff --checkWXT_SKIP_ENV_VALIDATION=true pnpm build169test files /1394tests)Manual verification
.output/chrome-mv3