feat: cancel export subtitle translations#1701
Conversation
🦋 Changeset detectedLatest commit: b4fe70c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1794748 to
06da06c
Compare
06da06c to
b4fe70c
Compare
Contributor trust score32/100 — Moderate This score estimates contributor familiarity with Outcome
Score breakdown
Signals used
Policy
Updated automatically when the PR changes or when a maintainer reruns the workflow. |
|
We have been busy with other features recently. This PR appears to modify the capabilities of our core underlying queue, which is quite risky, and we currently don't have time for a detailed review. I will mark this PR as "on hold" for now. When we have more time in the future, we will come back to review it. Sorry about that. |
Summary
Scope
This PR intentionally does not:
Validation
pnpm exec vitest run src/entrypoints/background/__tests__/translation-queues.test.tspnpm exec vitest run src/entrypoints/subtitles.content/__tests__/translated-subtitles-downloader.test.ts src/utils/subtitles/processor/__tests__/translator.test.tspnpm exec vitest run src/utils/request/__tests__/request-queue.test.ts src/utils/request/__tests__/batch-queue.test.tspnpm exec tsc --noEmit --pretty falsepnpm exec eslint src/entrypoints/background/translation-queues.ts src/entrypoints/background/__tests__/translation-queues.test.ts src/entrypoints/subtitles.content/translated-subtitles-downloader.ts src/entrypoints/subtitles.content/__tests__/translated-subtitles-downloader.test.ts src/utils/message.ts src/utils/request/request-queue.ts src/utils/request/batch-queue.ts src/utils/subtitles/processor/translator.ts src/utils/subtitles/processor/__tests__/translator.test.tsgit diff --check@read-frog/extension:lint,@read-frog/extension:type-check,@read-frog/extension:test(159 test files, 1341 tests)