Feat/shortcut keys to configure browser split screen by JackCmd233 · Pull Request #1413 · mengxi-ream/read-frog

JackCmd233 · 2026-04-28T11:39:43Z

Type of Changes

Description

This PR adds a split translator workflow that can be opened from the extension UI and used directly in the side panel.

It includes:

a new split translator UI with input, translation result, copy/retry actions, and target language selection
shortcut-related improvements, including settings support for viewing/configuring the split translator shortcut and page-level shortcut binding
stability fixes for stale validation/detection results, loading states, side panel close handling, and shortcut toggle failures
updated i18n copy for the new split translator and shortcut-related UI
expanded automated coverage for split translator flows, shortcut settings, navigation helpers, side panel behavior, and config migrations

Overall, these changes make the split translator easier to access, easier to configure, and more reliable during real usage.

Related Issue

Closes #1196

How Has This Been Tested?

Added unit tests covering split translator app flows, side panel behavior, shortcut binding/settings, navigation helpers, language detection handling, and config migration
Added unit tests
Verified through manual testing

Screenshots

Suggested screenshots to attach if needed:

split translator side panel UI
popup entry for split translator
translation settings page with split translator shortcut configuration

Checklist

I have tested these changes locally
I have updated the documentation accordingly if necessary
My code follows the code style of this project
My changes do not break existing functionality
If my code was generated by AI, I have proofread and improved it as necessary.

Additional Information

Most of the changes in this PR are part of the same split translator delivery thread, so the branch includes feature work, follow-up fixes, i18n updates, and test coverage improvements around the same user flow.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…browser-splitScreen

changeset-bot · 2026-04-28T11:39:48Z

⚠️ No Changeset found

Latest commit: 567c259

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2026-04-28T11:40:10Z

Contributor trust score

14/100 — New contributor

This score estimates contributor familiarity with mengxi-ream/read-frog using public GitHub signals. It is advisory only and does not block merges automatically.

Outcome

PR: Feat/shortcut keys to configure browser split screen #1413 — Feat/shortcut keys to configure browser split screen
Author: @JackCmd233
Trust label: contrib-trust:new
Maintainer review: required
Override label: add trust-check:skip to stop future trust automation updates

Score breakdown

Dimension	Score	Signals
Repo familiarity	0/35	commits in repo, merged PRs, reviews
Community standing	6/25	account age, followers, repo role
OSS influence	3/20	stars on owned non-fork repositories
PR track record	5/20	merge rate across resolved PRs in this repo

Signals used

Repo commits: 0 (author commits reachable from the repository default branch)
Repo PR history: merged 0, open 1, closed-unmerged 0
Repo reviews: 0
PR changed lines: 2521 (+2405 / -116)
Repo permission: read
Followers: 2
Account age: 104 months
Owned non-fork repos considered: max 2, total 4 (JackCmd233/FlowerShop (2), JackCmd233/LeetCode (2), JackCmd233/ai-code-helper (0), JackCmd233/mcp-mssql (0), JackCmd233/AI_Harness (0), JackCmd233/ChatGPT_Next_Web_Bak (0), JackCmd233/GPT_cloudflare (0), JackCmd233/chatgpt-on-wechat (0), JackCmd233/wechat-chatgpt (0), JackCmd233/ChatGPT-Web (0), JackCmd233/ChatGPT_Web_Bak (0), JackCmd233/WechatBot (0), JackCmd233/img (0), JackCmd233/Java8 (0), JackCmd233/CMDEGR_Index (0), JackCmd233/china_ip_list (0), JackCmd233/cmdegr.github.io (0))

Policy

Low-score review threshold: < 30
Auto-close: score < 20 and changed lines > 1000
Policy version: v1.1

Updated automatically when the PR changes or when a maintainer reruns the workflow.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b0a6e3d0b4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-28T11:46:16Z

+      source: "extension-user-action",
+      windowId: browser.windows.WINDOW_ID_CURRENT,
+    }))


Resolve a real window ID before toggling from popup

Passing browser.windows.WINDOW_ID_CURRENT here sends -2, but the background toggle logic stores open state in createSidePanelWindowState keyed by the provided windowId. Because -2 is reused for every window, state becomes cross-window and the first toggle in another window can be misclassified as already open (leading to a close/no-op/unsupported path instead of opening). Use the concrete current window id (or normalize -2 in background) before state tracking and side panel calls.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-28T11:46:16Z

+    () => {
+      void sendMessage("toggleSidePanel", undefined).catch((error) => {
+        logger.error("Failed to toggle split translator from shortcut", error)


Handle unsuccessful toggle responses in shortcut callback

This callback only logs rejected promises, but toggleSidePanel can resolve with { ok: false, reason: ... }. In Firefox, background returns requires-extension-user-action for content-script sourced requests, so the split-translator hotkey becomes a silent no-op with no user feedback or fallback. Check the resolved result and handle ok: false explicitly (or send an allowed source for this user gesture path).

Useful? React with 👍 / 👎.

…browser-splitScreen

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3a136529e4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-02T06:34:47Z

+const HAN_SCRIPT_RE = /[\u3400-\u9FFF\uF900-\uFAFF]/u
+
+function detectSplitTranslatorShortTextLanguage(text: string): LangCodeISO6393 | null {
+  const trimmedText = text.trim()
+  return trimmedText.length < MIN_LENGTH_FOR_SKIP_LLM_DETECTION && HAN_SCRIPT_RE.test(trimmedText) ? "cmn" : null


Restrict short-text Chinese override to Chinese-only inputs

The new short-text fast path marks any string containing a Han ideograph as cmn, which also matches Japanese kanji (and hanja), so short non-Chinese inputs like 日本語 are forced to Chinese and skip normal detection. In split-translator flows where source is auto, this can trigger incorrect same-language warnings and produce lower-quality or incorrect translations for short Japanese/Korean text because the detection signal is now biased before fallback detection runs.

Useful? React with 👍 / 👎.

…browser-splitScreen

github-actions · 2026-05-24T01:04:14Z

This PR has been inactive for 14 days and is now marked as stale.
It will be automatically closed in 30 days if no further activity occurs.

JackCmd233 and others added 30 commits April 27, 2026 12:48

feat: declare split translator command

023f761

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix: add split translator entrypoint shell

d52b200

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

feat: route split translator shortcut

8c44687

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix: use command tab window for split translator toggle

4397a03

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

feat: add split translator page shell

535f570

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

feat: add split translator translation hook

88de540

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix: ignore stale split translator validation results

c9db985

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix: suppress stale split translator validation toasts

eedd65b

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix: suppress stale split translator detection toasts

c6b2da2

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

feat: add split translator UI

f47b297

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

test: assert split translator input survives failures

08c7457

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

test: cover split translator retry behavior

318b06f

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix: retry split translator current input

d217059

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

feat: localize split translator panel

7b9da94

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix: make split translator the side panel entrypoint

75db24a

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

test: cover split translator loading region

885bb1b

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix: let split translator fill panel width

7c8b664

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

feat: add split translator target language selector

0eff2fd

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix: sync split translator target language after config load

ad20bc3

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix: retranslate split translator after target config changes

1cf251e

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix: disable split translator language selector while loading

e192e72

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix: defer split translator external target retranslate while loading

36ff351

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix: skip redundant split translator target replay

6e967c6

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

feat: add extension shortcut settings navigation

9d41d70

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

test: restore options navigation coverage

4592158

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

test: cover shortcut settings opener browsers

6b857e8

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

feat: add split translator shortcut settings entry

8a313e4

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix: use i18n interpolation for split shortcut description

e9f3874

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

style: sort translation settings imports

b5744aa

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

style: fix split shortcut settings lint

cc5fe0e

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

JackCmd233 and others added 10 commits April 28, 2026 13:24

fix: patch split translator shortcut setting

ff6bb39

feat: bind split translator shortcut on pages

363b32d

fix: handle split shortcut toggle failures

96b27ca

fix: detect short chinese split translator input

ac7d1c1

fix: limit split translator local language detection

2187484

fix: ignore stale split translator close failures

4cef004

fix: distinguish stale side panel close errors

81af4b9

fix: format split translator language detection

c029d52

fix: remove split translator browser command shortcut

e26a60f

Merge branch 'mengxi-ream:main' into feat/shortcut-keys-to-configure-…

b0a6e3d

…browser-splitScreen

github-actions Bot added contrib-trust:new PR author trust score is 0-29. needs-maintainer-review Contributor trust automation recommends maintainer review. labels Apr 28, 2026

github-actions Bot closed this Apr 28, 2026

chatgpt-codex-connector Bot reviewed Apr 28, 2026

View reviewed changes

mengxi-ream added the trust-check:skip Skip contributor trust automation on this PR. label May 1, 2026

mengxi-ream reopened this May 1, 2026

github-actions Bot removed the needs-maintainer-review Contributor trust automation recommends maintainer review. label May 1, 2026

JackCmd233 and others added 2 commits May 2, 2026 14:21

Merge branch 'mengxi-ream:main' into feat/shortcut-keys-to-configure-…

9177b75

…browser-splitScreen

fix: update split translator button to use current window ID dynamically

3a13652

chatgpt-codex-connector Bot reviewed May 2, 2026

View reviewed changes

Merge branch 'mengxi-ream:main' into feat/shortcut-keys-to-configure-…

567c259

…browser-splitScreen

This was referenced May 9, 2026

[FEATURE] Standalone Text Translation Input within Extension Popup #1196

Open

[FEATURE] 希望点击扩展能有输入框快速翻译 #1491

Open

frogGuaGuaGuaGua mentioned this pull request May 16, 2026

[FEATURE] 移动端手势操作 #1525

Open

2 tasks

github-actions Bot added the Stale label May 24, 2026

mengxi-ream added the on-hold label May 25, 2026

0-o0 mentioned this pull request Jun 11, 2026

feat: Optimize translation-hub to support split-screen mode #1681

Open

20 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feat/shortcut keys to configure browser split screen#1413

Feat/shortcut keys to configure browser split screen#1413
JackCmd233 wants to merge 60 commits into
mengxi-ream:mainfrom
JackCmd233:feat/shortcut-keys-to-configure-browser-splitScreen

JackCmd233 commented Apr 28, 2026 •

edited by mengxi-ream

Loading

Uh oh!

changeset-bot Bot commented Apr 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Apr 28, 2026

Uh oh!

chatgpt-codex-connector Bot Apr 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot May 2, 2026

Uh oh!

github-actions Bot commented May 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

JackCmd233 commented Apr 28, 2026 • edited by mengxi-ream Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Changes

Description

Related Issue

How Has This Been Tested?

Screenshots

Checklist

Additional Information

Uh oh!

changeset-bot Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions Bot commented Apr 28, 2026

Contributor trust score

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 2, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JackCmd233 commented Apr 28, 2026 •

edited by mengxi-ream

Loading

changeset-bot Bot commented Apr 28, 2026 •

edited

Loading