fix(translate): avoid redundant skip-language LLM detection#1354
Open
frogGuaGuaGuaGua wants to merge 1 commit into
Open
fix(translate): avoid redundant skip-language LLM detection#1354frogGuaGuaGuaGua wants to merge 1 commit into
frogGuaGuaGuaGua wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 6e47c6d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Contributor trust score42/100 — Moderate This score estimates contributor familiarity with Outcome
Score breakdown
Signals used
Policy
Updated automatically when the PR changes or when a maintainer reruns the workflow. |
2 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1353
Related: #1110
Summary
Why
Current
mainstill callsshouldSkipByLanguage(preparedText, skipLanguages, config.languageDetection.mode === "llm")insidesrc/utils/host/translate/translate-variants.ts, so page translation can make an extra LLM language-detection call before the real LLM translation call.For the behavior reported in #1353, the skip-language check should stay franc-only when page translation itself is using an LLM provider. Non-LLM translation providers should continue using the configured LLM language detection path.
Implementation
shouldSkipByLanguage(...)withconfig.languageDetection.mode === "llm" && !isLLMProviderConfig(providerConfig)insrc/utils/host/translate/translate-variants.tssrc/utils/host/translate/__tests__/translate-variants.test.tsto assert:openai-default->shouldSkipByLanguage(..., false)microsoft-translate-default->shouldSkipByLanguage(..., true).changeset/fresh-guests-sit.mdValidation
SKIP_FREE_API=true pnpm exec vitest run --configLoader runner src/utils/host/translate/__tests__/skip-language.test.ts src/utils/host/translate/__tests__/translate-variants.test.tspnpm exec eslint src/utils/host/translate/translate-variants.ts src/utils/host/translate/__tests__/translate-variants.test.tspnpm run type-checknx run @read-frog/extension:lintnx run @read-frog/extension:type-checknx run @read-frog/extension:test