Skip to content

[WC-3037] RichText: Modal form orientation #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

yordan-st
Copy link
Collaborator

@yordan-st yordan-st commented Aug 5, 2025

Pull request type

New feature (non-breaking change which adds functionality)


Description

Added support to configure the form orientation of modals, via the widget properties in Studio Pro.

Now Developers can configure this in the same way as this is done with regular TextBoxes in a DataView

What should be covered while testing?

  • Toggle 'vertical' or 'horizontal' orientation in the General tab, Editability section
  • Run app and check if this changed the orientation for add Link, Image and Video modals
  • Inspect if this correctly changed the classes to 'vertical' or 'horizontal'
  • Inspect if the 'for' and 'id' attributes of the labels and inputs correspond to eachother
  • Inspect if the DOM structure changes. Similar to regular TextBoxes in DataViews, the DOM should be different when toggling between orientations.

@yordan-st yordan-st marked this pull request as ready for review August 6, 2025 13:34
@yordan-st yordan-st requested a review from a team as a code owner August 6, 2025 13:34
@yordan-st yordan-st changed the title feat: add form orientation property to rich text modal dialogs and co… [WC-3037] Aug 6, 2025
@yordan-st yordan-st changed the title [WC-3037] [WC-3037] RichText: Modal form orientation Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants