-
Notifications
You must be signed in to change notification settings - Fork 55
[WC-3026] Combobox: Enable onFilterInputChange action with ActionVariables #1782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjulivan
reviewed
Jul 23, 2025
packages/pluggableWidgets/combobox-web/src/components/MultiSelection/MultiSelection.tsx
Outdated
Show resolved
Hide resolved
gjulivan
reviewed
Jul 23, 2025
packages/pluggableWidgets/combobox-web/src/hooks/useDownshiftMultiSelectProps.ts
Outdated
Show resolved
Hide resolved
gjulivan
reviewed
Jul 23, 2025
packages/pluggableWidgets/combobox-web/src/hooks/useGetSelector.ts
Outdated
Show resolved
Hide resolved
gjulivan
reviewed
Jul 23, 2025
packages/pluggableWidgets/combobox-web/src/hooks/useGetSelector.ts
Outdated
Show resolved
Hide resolved
9556e3f
to
83f416c
Compare
gjulivan
previously approved these changes
Jul 28, 2025
gjulivan
reviewed
Jul 30, 2025
packages/pluggableWidgets/combobox-web/src/components/SingleSelection/SingleSelection.tsx
Outdated
Show resolved
Hide resolved
gjulivan
reviewed
Jul 30, 2025
packages/pluggableWidgets/combobox-web/src/hooks/useDownshiftSingleSelectProps.ts
Outdated
Show resolved
Hide resolved
gjulivan
reviewed
Jul 31, 2025
packages/pluggableWidgets/combobox-web/src/hooks/useDownshiftMultiSelectProps.ts
Outdated
Show resolved
Hide resolved
gjulivan
reviewed
Jul 31, 2025
packages/pluggableWidgets/combobox-web/src/hooks/useGetSelector.ts
Outdated
Show resolved
Hide resolved
5f3a517
to
8e7b857
Compare
gjulivan
reviewed
Aug 4, 2025
packages/pluggableWidgets/combobox-web/src/hooks/useDownshiftSingleSelectProps.ts
Outdated
Show resolved
Hide resolved
gjulivan
previously approved these changes
Aug 5, 2025
b0e0d9a
to
78c9235
Compare
78c9235
to
8db8e67
Compare
leonardomendix
approved these changes
Aug 11, 2025
gjulivan
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
New feature (non-breaking change which adds functionality)
Description
Added new event onChangeFilterInputEvent that triggers when users type in combobox filter field, passing the current filter text as an action variable.
This enables developers to execute custom nanoflows/microflows in response to filter input changes for dynamic filtering, search logging, or validation scenarios.
What should be covered while testing?
Configure Filter Input Action
Expected Behavior