Skip to content

OIDC Provider Module #5616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
May 4, 2023
Merged

OIDC Provider Module #5616

merged 23 commits into from
May 4, 2023

Conversation

MarkvanMents
Copy link
Collaborator

@MarkvanMents MarkvanMents commented Feb 7, 2023

Marketplace Module to allow customers to be their own OIDC Identity Provider.
See also #5482 to be published at the same time?

Copy link
Collaborator Author

@MarkvanMents MarkvanMents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've responded to your comments so far and proofread the document in this commit: 9a2fca3
I will add some more comments for discussion.

Copy link
Collaborator Author

@MarkvanMents MarkvanMents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @SharishmaPodduturi999
I've added a few more questions.


## 1 Introduction

{{% todo %}}Add link to module in Marketplace{{% /todo %}}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add a link to the module.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarkvanMents As it is not yet published on Marketplace, I will add the comment here once I publish the module

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

@MarkvanMents MarkvanMents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SharishmaPodduturi999,
I've responded to your comments in commit f5dd3a8.
I have also asked a couple of other questions which would help me make the documentation clearer. Please can you have a look and see if you can answer them?

Will #5482 be published at the same time. If so, I can merge it here and we can work on all the files together?

Copy link
Collaborator Author

@MarkvanMents MarkvanMents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments which were in the original paper (some now six months old) which I'm not sure we have fully addressed in this documentation?

Copy link
Collaborator Author

@MarkvanMents MarkvanMents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JaapF and @SharishmaPodduturi999
I have made some suggestions for changes, and added the information about end-user account creation.
Still a couple of things to work on, but hope to finish tomorrow (25 April).

I don't think you can commit my changes, but if you can approve them with a thumbs-up - or make a comment if you disagree. Thanks.

Copy link
Collaborator Author

@MarkvanMents MarkvanMents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responded to some more of the review comments.
Now awaiting confirmation that other suggestions are OK.


{{% todo %}}Where was MxObjects set up? I don't think we have any navigation to this page set up in 3.2?{{% /todo %}}

1. Open the MxObjects overview page and synchronize the required modules to see the new microflow.

This comment was marked as resolved.

Copy link
Collaborator Author

@MarkvanMents MarkvanMents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responded to final review.

@MarkvanMents MarkvanMents merged commit a3be064 into development May 4, 2023
@MarkvanMents MarkvanMents deleted the MvM-OIDCProvider branch May 4, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants