chore: fail deployment on spontaneous reboot #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielskinstad
force-pushed
the
spontaneous_reboot
branch
from
6621c64 to
27d6250
Compare
See motivation for this change: - https://docs.mender.io/artifact-creation/state-scripts#power-loss A spontaneous reboot / power loss is detected when the stored state is something other than `MENDER_UPDATE_STATE_VERIFY_REBOOT` or `MENDER_UPDATE_STATE_ROLLBACK_VERIFY_REBOOT`. Ticket: MEN-8197 Signed-off-by: Daniel Skinstad Drabitzius <[email protected]>
danielskinstad
force-pushed
the
spontaneous_reboot
branch
from
27d6250 to
89ebbfa
Compare
vpodzime
reviewed
Mar 14, 2025
There was a problem hiding this comment.
Generally I don't think it's a good idea to use a negative condition in one place (not one of these two states) and then add handling of the case based on a positive condition (is one of these states). I'd prefer using the same condition in both places -- client initialization and the work function. And I'd probably even do it before the while-switch block.
| spontaneous_reboot = false; | ||
| ret = MENDER_FAIL; | ||
| NEXT_STATE; | ||
| } |
There was a problem hiding this comment.
What about the REBOOT state?
There was a problem hiding this comment.
The docs say Power loss is allowed to happen within any Reboot state, since it may be indistinguishable from a normal reboot
| /* Check for a spontaneous reboot */ | ||
| mender_update_state_t update_state; | ||
| if (MENDER_OK == (ret = mender_deployment_data_get_state(mender_client_deployment_data, &update_state))) { | ||
| if ((MENDER_UPDATE_STATE_VERIFY_REBOOT != update_state) && (MENDER_UPDATE_STATE_ROLLBACK_VERIFY_REBOOT != update_state)) { |
There was a problem hiding this comment.
DOWNLOAD state should be ok, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See motivation for this change:
A spontaneous reboot / power loss is detected when the stored state is something other than
MENDER_UPDATE_STATE_VERIFY_REBOOTorMENDER_UPDATE_STATE_ROLLBACK_VERIFY_REBOOT.Ticket: MEN-8197