Remove dangerous commands

README.md

@@ -52,8 +52,6 @@ GPT AI Assistant 是基於 OpenAI API 與 LINE Messaging API 實作的範例應
 名稱 | 說明
 --- | ---
 `/version` | 取得版本資訊
-`/env` | 取得環境變數
-`/env KEY=VALUE` | 設置環境變數
 
 ## 環境變數
 

assistant/assistant.js

@@ -19,8 +19,6 @@ import Prompt from './prompt.js';
 class Assistant {
   version;
 
-  owner;
-
   prompts = new Map();
 
   constructor() {
@@ -45,24 +43,13 @@ class Assistant {
    * @returns {Object}
    */
   async handleEvent(event) {
-    if (!this.owner) this.setOwner(event.userId);
     if (event.isCommandGetVersion) {
       event.pushReply(this.version);
       if (this.version !== (await fetchVersion())) {
         event.pushReply('A new version of GPT AI Assistant is available. Please update source code.');
       }
       return event;
     }
-    if (event.userId === this.owner) {
-      if (event.isCommandGetEnv) {
-        event.handleCommandGetEnv(config);
-        return event;
-      }
-      if (event.isCommandSetEnv) {
-        event.handleCommandSetEnv(config);
-        return event;
-      }
-    }
     try {
       const prompt = this.getPrompt(event.userId);
       prompt.write(`${PARTICIPANT_HUMAN}: ${event.text}？`);
@@ -77,10 +64,6 @@ class Assistant {
     }
   }
 
-  setOwner(userId) {
-    this.owner = userId;
-  }
-
   /**
    * @param {string} userId
    * @returns {Prompt}

assistant/event.js

@@ -1,7 +1,5 @@
 import {
   COMMAND_GET_VERSION,
-  COMMAND_GET_ENV,
-  COMMAND_SET_ENV,
 } from '../constants/command/index.js';
 
 class Event {
@@ -29,29 +27,6 @@ class Event {
     return this.text.toLowerCase() === COMMAND_GET_VERSION;
   }
 
-  get isCommandGetEnv() {
-    return this.text.toLowerCase() === COMMAND_GET_ENV;
-  }
-
-  get isCommandSetEnv() {
-    return this.text.toLowerCase().startsWith(COMMAND_SET_ENV);
-  }
-
-  get getCommandArgs() {
-    return this.text.slice(COMMAND_SET_ENV.length).trim().split('=');
-  }
-
-  handleCommandGetEnv(config) {
-    this.pushReply(`${JSON.stringify(config, null, 2)}`);
-  }
-
-  handleCommandSetEnv(config) {
-    const [key, value] = this.getCommandArgs;
-    config.set(key, value);
-    this.pushReply(`${key}=${config.get(key)}`);
-    return this;
-  }
-
   pushReply(reply) {
     this.replies.push(reply);
   }

assistant/index.test.js

@@ -10,8 +10,6 @@ import {
 } from '../services/line/index.js';
 import {
   COMMAND_GET_VERSION,
-  COMMAND_GET_ENV,
-  COMMAND_SET_ENV,
 } from '../constants/command/index.js';
 import Assistant from './assistant.js';
 
@@ -73,41 +71,3 @@ test('get version command works', async () => {
   ]);
   expect(actual).toEqual(expected);
 }, TIMEOUT);
-
-test('get env command works', async () => {
-  const assistant = new Assistant();
-  const events = createEvents([COMMAND_GET_ENV]);
-  let actual;
-  try {
-    actual = await assistant.handleEvents(events);
-  } catch (err) {
-    console.error(err.toJSON());
-  }
-  const expected = expect.arrayContaining([
-    expect.objectContaining({
-      replies: expect.arrayContaining([
-        `${JSON.stringify(config, null, 2)}`,
-      ]),
-    }),
-  ]);
-  expect(actual).toEqual(expected);
-}, TIMEOUT);
-
-test('set env command works', async () => {
-  const assistant = new Assistant();
-  const events = createEvents([`${COMMAND_SET_ENV} APP_PORT=80`]);
-  let actual;
-  try {
-    actual = await assistant.handleEvents(events);
-  } catch (err) {
-    console.error(err.toJSON());
-  }
-  const expected = expect.arrayContaining([
-    expect.objectContaining({
-      replies: expect.arrayContaining([
-        'APP_PORT=80',
-      ]),
-    }),
-  ]);
-  expect(actual).toEqual(expected);
-}, TIMEOUT);

constants/command/index.js

@@ -1,5 +1,3 @@
 export const COMMAND_GET_VERSION = '/version';
-export const COMMAND_GET_ENV = '/env';
-export const COMMAND_SET_ENV = '/env ';
 
 export default null;