Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fixes for openFrameworks 0.11.2 #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hiroyuki
Copy link

  • replaced ofPoint to glm::vec3
  • change testApp to ofApp
  • and test compile basic example ( need to change file name above )

warning: ofxIlda example RenderTarget still needs to be fixed.

@memo
Copy link
Owner

memo commented Oct 17, 2022

Hi, thx so much for doing this. is ofPoint deprecated? I would have thought, for future compatibility, it would make more sense to keep an OF type (such as ofPoint, or ofVec2f, or ofVec3f) - even if internally typedef'ed to glm:vec3, just so that in the future, if glm is replaced, older codebases would carry on working?

@hiroyuki
Copy link
Author

Hi,
Thanks for your great addon!
Yes, I agree it would be great if it works with OF type and your concern about the future replacement of glm.
I just thought it is better to keep your nice addon straightforward to use.
Especially for people unfamiliar with old OF syntax, it can be hard to fix them by themselves.

@memo
Copy link
Owner

memo commented Oct 19, 2022

oh but does it currently not work? has ofPoint been removed? or ofVec2f?

@hiroyuki
Copy link
Author

No it's not working.
The ofPoint is not removed but the interfaces of oF functions replaced it with glm mostly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants