Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align develop and main branch #237

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Align develop and main branch #237

merged 1 commit into from
Apr 7, 2023

Conversation

katarinasupe
Copy link
Contributor

Aligning develop and main branch.

[main < develop] Release GQLAlchemy 1.4
@katarinasupe katarinasupe merged commit 5f772d2 into develop Apr 7, 2023
katarinasupe added a commit that referenced this pull request Sep 20, 2023
* Align develop and main branch (#237)

Co-authored-by: Bruno Sačarić <[email protected]>

* Inject a GetOrCreateMixin to Node and Relationship.

* Use the imported GQLAlchemyError instead of a fully qualified path.

* Use the imported Tuple instead of fully qualified typing.Tuple

* Run black.

* suppress flake8's f821 on get_or_create definition

* Add tests for get_or_create and refactor the mixin into separate implementations for improved docs.

Signed-off-by: Aalekh Patel <[email protected]>

* Apply black.

Signed-off-by: Aalekh Patel <[email protected]>

* Apply black to tests as well.

Signed-off-by: Aalekh Patel <[email protected]>

* typo fix in function signature.

Signed-off-by: Aalekh Patel <[email protected]>

* Assert the counts of nodes and relationships in the test.

Signed-off-by: Aalekh Patel <[email protected]>

* Apply black.

Signed-off-by: Aalekh Patel <[email protected]>

* Add the .execute() to the query builder in failing tests and provide "name" to the node instantiation because it is a required field.

* another attempt to fix the query builder usage in tests.

* apply black fixes.

* Fix tests by relying on the database identifier `_id` instead of the user-defined `id`.

Signed-off-by: Aalekh Patel <[email protected]>

* Remove unused test functions.

Signed-off-by: Aalekh Patel <[email protected]>

---------

Signed-off-by: Aalekh Patel <[email protected]>
Co-authored-by: Katarina Supe <[email protected]>
Co-authored-by: Bruno Sačarić <[email protected]>
Co-authored-by: katarinasupe <[email protected]>
Co-authored-by: Aalekh Patel <[email protected]>
andrejtonev pushed a commit that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants