Skip to content

Update on HA timeouts #1281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update on HA timeouts #1281

wants to merge 3 commits into from

Conversation

as51340
Copy link
Contributor

@as51340 as51340 commented May 9, 2025

Release note

Added new timeouts configuration for StateCheckRpc and FrequentHearbeatRpc. Explained why we need socket timeouts.

Related product PRs

PRs from product repo this doc page is related to:
memgraph/memgraph#2949

Checklist:

  • Add appropriate milestone (current release cycle)
  • Add bugfix or feature label, based on the product PR type you're documenting
  • Make sure all relevant tech details are documented
  • Check all content with Grammarly
  • Perform a self-review of my code
  • The build passes locally
  • My changes generate no new warnings or errors

@as51340 as51340 added this to the Memgraph 3.3 milestone May 9, 2025
@as51340 as51340 self-assigned this May 9, 2025
@as51340 as51340 added status: ready PR is ready for review feature Documentation related to a new product feature of feature update labels May 9, 2025
Copy link

vercel bot commented May 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2025 6:46pm

Copy link
Contributor

@antejavor antejavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you have have open this from main, can we move this to release branch?

Comment on lines +441 to +444
Except timeouts on read and write operations, Memgraph also has a timeout of 5s
for sockets when establishing connection. Such a timeout helps in having low p99
latencies when using RPC stack which manifests for users as smooth and predictable
network communication between instances.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Except timeouts on read and write operations, Memgraph also has a timeout of 5s
for sockets when establishing connection. Such a timeout helps in having low p99
latencies when using RPC stack which manifests for users as smooth and predictable
network communication between instances.
Except for timeouts on read and write operations, Memgraph also has a timeout of 5s
for sockets when establishing a connection. Such a timeout helps in having a low p99
latencies when using the RPC stack, which manifests for users as smooth and predictable
network communication between instances.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to merge the suggestion. The PR should be merged into main, not ha-timeouts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Documentation related to a new product feature of feature update status: ready PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants